Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Unified Diff: src/frames.h

Issue 12254007: Make the Isolate parameter mandatory for internal HandleScopes. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Rebased Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/elements.cc ('k') | src/frames.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/frames.h
diff --git a/src/frames.h b/src/frames.h
index a60e535947f033a9e5083e44da4e1aea831d0dab..595e58f1edf2bf6b976d382f98617820cc7d01e2 100644
--- a/src/frames.h
+++ b/src/frames.h
@@ -561,7 +561,10 @@ class JavaScriptFrame: public StandardFrame {
return static_cast<JavaScriptFrame*>(frame);
}
- static void PrintTop(FILE* file, bool print_args, bool print_line_number);
+ static void PrintTop(Isolate* isolate,
+ FILE* file,
+ bool print_args,
+ bool print_line_number);
protected:
inline explicit JavaScriptFrame(StackFrameIterator* iterator);
@@ -738,10 +741,6 @@ class ConstructFrame: public InternalFrame {
class StackFrameIterator BASE_EMBEDDED {
public:
- // An iterator that iterates over the current thread's stack,
- // and uses current isolate.
- StackFrameIterator();
-
// An iterator that iterates over the isolate's current thread's stack,
explicit StackFrameIterator(Isolate* isolate);
@@ -801,8 +800,6 @@ class StackFrameIterator BASE_EMBEDDED {
template<typename Iterator>
class JavaScriptFrameIteratorTemp BASE_EMBEDDED {
public:
- JavaScriptFrameIteratorTemp() { if (!done()) Advance(); }
-
inline explicit JavaScriptFrameIteratorTemp(Isolate* isolate);
inline JavaScriptFrameIteratorTemp(Isolate* isolate, ThreadLocalTop* top);
@@ -961,6 +958,8 @@ class SafeStackTraceFrameIterator: public SafeJavaScriptFrameIterator {
class StackFrameLocator BASE_EMBEDDED {
public:
+ explicit StackFrameLocator(Isolate* isolate) : iterator_(isolate) {}
+
// Find the nth JavaScript frame on the stack. The caller must
// guarantee that such a frame exists.
JavaScriptFrame* FindJavaScriptFrame(int n);
@@ -972,7 +971,7 @@ class StackFrameLocator BASE_EMBEDDED {
// Reads all frames on the current stack and copies them into the current
// zone memory.
-Vector<StackFrame*> CreateStackMap(Zone* zone);
+Vector<StackFrame*> CreateStackMap(Isolate* isolate, Zone* zone);
} } // namespace v8::internal
« no previous file with comments | « src/elements.cc ('k') | src/frames.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698