Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Unified Diff: src/elements.cc

Issue 12254007: Make the Isolate parameter mandatory for internal HandleScopes. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Rebased Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/debug.cc ('k') | src/frames.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/elements.cc
diff --git a/src/elements.cc b/src/elements.cc
index d0b6c3b348579a1ed51c9def1d5810b28115c104..b9a008cf5be7956cbcd422617d03f90cf64a7494 100644
--- a/src/elements.cc
+++ b/src/elements.cc
@@ -483,8 +483,8 @@ static void CopyDictionaryToDoubleElements(FixedArrayBase* from_base,
}
-static void TraceTopFrame() {
- StackFrameIterator it;
+static void TraceTopFrame(Isolate* isolate) {
+ StackFrameIterator it(isolate);
if (it.done()) {
PrintF("unknown location (no JavaScript frames present)");
return;
@@ -500,7 +500,7 @@ static void TraceTopFrame() {
raw_frame = it.frame();
}
}
- JavaScriptFrame::PrintTop(stdout, false, true);
+ JavaScriptFrame::PrintTop(isolate, stdout, false, true);
}
@@ -527,17 +527,17 @@ void CheckArrayAbuse(JSObject* obj, const char* op, uint32_t key,
elements_type, op, elements_type,
static_cast<int>(int32_length),
static_cast<int>(key));
- TraceTopFrame();
+ TraceTopFrame(obj->GetIsolate());
PrintF("]\n");
}
} else {
PrintF("[%s elements length not integer value in ", elements_type);
- TraceTopFrame();
+ TraceTopFrame(obj->GetIsolate());
PrintF("]\n");
}
} else {
PrintF("[%s elements length not a number in ", elements_type);
- TraceTopFrame();
+ TraceTopFrame(obj->GetIsolate());
PrintF("]\n");
}
}
« no previous file with comments | « src/debug.cc ('k') | src/frames.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698