Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1295)

Side by Side Diff: src/api.cc

Issue 12254007: Make the Isolate parameter mandatory for internal HandleScopes. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Rebased Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/accessors.cc ('k') | src/bootstrapper.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4542 matching lines...) Expand 10 before | Expand all | Expand 10 after
4553 proxy_constructor->set_needs_access_check( 4553 proxy_constructor->set_needs_access_check(
4554 global_constructor->needs_access_check()); 4554 global_constructor->needs_access_check());
4555 global_constructor->set_needs_access_check(false); 4555 global_constructor->set_needs_access_check(false);
4556 global_constructor->set_access_check_info( 4556 global_constructor->set_access_check_info(
4557 isolate->heap()->undefined_value()); 4557 isolate->heap()->undefined_value());
4558 } 4558 }
4559 } 4559 }
4560 4560
4561 // Create the environment. 4561 // Create the environment.
4562 env = isolate->bootstrapper()->CreateEnvironment( 4562 env = isolate->bootstrapper()->CreateEnvironment(
4563 isolate,
4564 Utils::OpenHandle(*global_object, true), 4563 Utils::OpenHandle(*global_object, true),
4565 proxy_template, 4564 proxy_template,
4566 extensions); 4565 extensions);
4567 4566
4568 // Restore the access check info on the global template. 4567 // Restore the access check info on the global template.
4569 if (!global_template.IsEmpty()) { 4568 if (!global_template.IsEmpty()) {
4570 ASSERT(!global_constructor.is_null()); 4569 ASSERT(!global_constructor.is_null());
4571 ASSERT(!proxy_constructor.is_null()); 4570 ASSERT(!proxy_constructor.is_null());
4572 global_constructor->set_access_check_info( 4571 global_constructor->set_access_check_info(
4573 proxy_constructor->access_check_info()); 4572 proxy_constructor->access_check_info());
(...skipping 1977 matching lines...) Expand 10 before | Expand all | Expand 10 after
6551 #else 6550 #else
6552 if (run == GetStressRuns() - 1) { 6551 if (run == GetStressRuns() - 1) {
6553 SetFlagsFromString(kForcedOptimizations); 6552 SetFlagsFromString(kForcedOptimizations);
6554 } else if (run != GetStressRuns() - 2) { 6553 } else if (run != GetStressRuns() - 2) {
6555 SetFlagsFromString(kLazyOptimizations); 6554 SetFlagsFromString(kLazyOptimizations);
6556 } 6555 }
6557 #endif 6556 #endif
6558 } 6557 }
6559 6558
6560 6559
6560 // TODO(svenpanne) Deprecate this.
6561 void Testing::DeoptimizeAll() { 6561 void Testing::DeoptimizeAll() {
6562 i::HandleScope scope; 6562 i::Isolate* isolate = i::Isolate::Current();
6563 i::HandleScope scope(isolate);
6563 internal::Deoptimizer::DeoptimizeAll(); 6564 internal::Deoptimizer::DeoptimizeAll();
6564 } 6565 }
6565 6566
6566 6567
6567 namespace internal { 6568 namespace internal {
6568 6569
6569 6570
6570 void HandleScopeImplementer::FreeThreadResources() { 6571 void HandleScopeImplementer::FreeThreadResources() {
6571 Free(); 6572 Free();
6572 } 6573 }
(...skipping 130 matching lines...) Expand 10 before | Expand all | Expand 10 after
6703 6704
6704 v->VisitPointers(blocks_.first(), first_block_limit_); 6705 v->VisitPointers(blocks_.first(), first_block_limit_);
6705 6706
6706 for (int i = 1; i < blocks_.length(); i++) { 6707 for (int i = 1; i < blocks_.length(); i++) {
6707 v->VisitPointers(blocks_[i], &blocks_[i][kHandleBlockSize]); 6708 v->VisitPointers(blocks_[i], &blocks_[i][kHandleBlockSize]);
6708 } 6709 }
6709 } 6710 }
6710 6711
6711 6712
6712 } } // namespace v8::internal 6713 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/accessors.cc ('k') | src/bootstrapper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698