src/heap.cc - Issue 12254007: Make the Isolate parameter mandatory for internal HandleScopes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap.cc

Issue 12254007: Make the Isolate parameter mandatory for internal HandleScopes. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Rebased Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/heap.cc

diff --git a/src/heap.cc b/src/heap.cc

index 8cef1aea5394f07db103f61e639695339bcb8343..da7236bce26419f13df98e79ece6648ac26c2ddc 100644

--- a/src/heap.cc

+++ b/src/heap.cc

@@ -2704,7 +2704,7 @@ void Heap::CreateFixedStubs() {

// for cooking and uncooking (check out frames.cc).

// The eliminates the need for doing dictionary lookup in the

// stub cache for these stubs.

- HandleScope scope;

+ HandleScope scope(isolate());

// gcc-4.4 has problem generating correct code of following snippet:

// { JSEntryStub stub;

// js_entry_code_ = *stub.GetCode();

« no previous file with comments | « src/handles-inl.h ('k') | src/ic.cc » ('j') | no next file with comments »