Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 1222453002: [Feedback] Use callbacks for FeedbackCollector and use ScreenshotTask (Closed)

Created:
5 years, 5 months ago by nyquist
Modified:
5 years, 5 months ago
Reviewers:
gone
CC:
chromium-reviews, David Trainor- moved to gerrit, avayvod+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@add-feedback-collector-test
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Feedback] Use callbacks for FeedbackCollector and use ScreenshotTask This CL adds support for using callbacks with the FeedbackCollector. The FeedbackCollector now always waits for the screenshot, and waits up to 500 ms for connectivity checks to finish. If taking the screenshot takes a long time, the connectivity checks get more time to finish. The callback for the FeedbackCollector is called when both these statements are true: - Screenshot is finished. - Connectivity checks are finished or timeout has expired. Additional required steps part of this CL: - Start gathering screenshots using the ScreenshotTask. - Update all callers of HelpAndFeedback and the FeedbackCollector. BUG=386395 Committed: https://crrev.com/a79fb716f855029ab0f35eb11b666b3bed80fb3d Cr-Commit-Position: refs/heads/master@{#337131}

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Merged in parent branch and changed CONNECTIVITY_CHECK_TIMEOUT_MS back to 5000 #

Patch Set 4 : Squashed branch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+334 lines, -58 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java View 2 chunks +4 lines, -14 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/Tab.java View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/childaccounts/ChildAccountFeedbackReporter.java View 1 chunk +12 lines, -9 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/DomDistillerFeedbackReporter.java View 1 chunk +13 lines, -6 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/feedback/FeedbackCollector.java View 1 2 3 5 chunks +110 lines, -8 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/help/HelpAndFeedback.java View 2 chunks +24 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPage.java View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/LearnMorePreference.java View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/Preferences.java View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferences.java View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/website/TranslatePreferences.java View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/android/javatests_shell/src/org/chromium/chrome/browser/feedback/FeedbackCollectorTest.java View 1 2 3 7 chunks +163 lines, -6 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 21 (10 generated)
nyquist
dfalcantara: PTAL
5 years, 5 months ago (2015-06-30 21:02:57 UTC) #2
gone
lgtm
5 years, 5 months ago (2015-07-01 18:50:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1222453002/40001
5 years, 5 months ago (2015-07-01 21:27:37 UTC) #6
commit-bot: I haz the power
Exceeded global retry quota
5 years, 5 months ago (2015-07-01 21:29:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1222453002/40001
5 years, 5 months ago (2015-07-01 21:34:10 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/69608)
5 years, 5 months ago (2015-07-01 21:38:04 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1222453002/40001
5 years, 5 months ago (2015-07-01 21:52:27 UTC) #14
commit-bot: I haz the power
Exceeded global retry quota
5 years, 5 months ago (2015-07-01 21:55:38 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1222453002/60001
5 years, 5 months ago (2015-07-01 22:22:39 UTC) #19
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 5 months ago (2015-07-01 23:05:09 UTC) #20
commit-bot: I haz the power
5 years, 5 months ago (2015-07-01 23:07:09 UTC) #21
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/a79fb716f855029ab0f35eb11b666b3bed80fb3d
Cr-Commit-Position: refs/heads/master@{#337131}

Powered by Google App Engine
This is Rietveld 408576698