chrome/android/java/src/org/chromium/chrome/browser/Tab.java - Issue 1222453002: [Feedback] Use callbacks for FeedbackCollector and use ScreenshotTask

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/Tab.java

Issue 1222453002: [Feedback] Use callbacks for FeedbackCollector and use ScreenshotTask (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@add-feedback-collector-test

Patch Set: Squashed branch Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/childaccounts/ChildAccountFeedbackReporter.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/Tab.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/Tab.java b/chrome/android/java/src/org/chromium/chrome/browser/Tab.java

index 1a5933485bfadc2b4125f5b4b18a6208adf49674..5f411b5e6a03e5a2f488799fb52e390bc90aed8a 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/Tab.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/Tab.java

@@ -37,7 +37,6 @@ import org.chromium.chrome.browser.contextmenu.ContextMenuParams;

import org.chromium.chrome.browser.contextmenu.ContextMenuPopulator;

import org.chromium.chrome.browser.contextmenu.ContextMenuPopulatorWrapper;

import org.chromium.chrome.browser.contextmenu.EmptyChromeContextMenuItemDelegate;

-import org.chromium.chrome.browser.feedback.FeedbackCollector;

import org.chromium.chrome.browser.fullscreen.FullscreenManager;

import org.chromium.chrome.browser.help.HelpAndFeedback;

import org.chromium.chrome.browser.infobar.InfoBarContainer;

@@ -1668,9 +1667,9 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener,

public void onClick(View view) {

Activity activity = mWindowAndroid.getActivity().get();

assert activity != null;

- HelpAndFeedback.getInstance(activity).show(

- activity, activity.getString(R.string.help_context_sad_tab),

- FeedbackCollector.create(Profile.getLastUsedProfile(), null));

+ HelpAndFeedback.getInstance(activity).show(activity,

+ activity.getString(R.string.help_context_sad_tab),

+ Profile.getLastUsedProfile(), null);

}

};

OnClickListener reloadButtonAction = new OnClickListener() {