chrome/android/java/src/org/chromium/chrome/browser/preferences/Preferences.java - Issue 1222453002: [Feedback] Use callbacks for FeedbackCollector and use ScreenshotTask

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/Preferences.java

Issue 1222453002: [Feedback] Use callbacks for FeedbackCollector and use ScreenshotTask (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@add-feedback-collector-test

Patch Set: Squashed branch Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/preferences/LearnMorePreference.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferences.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/Preferences.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/Preferences.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/Preferences.java

index d8d8c4c2c6fd0c31c4fe0c76f5738a145e5aeebc..3fb2bc9521e69b410a7924448d44cf47fafbaf09 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/Preferences.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/Preferences.java

@@ -32,7 +32,6 @@ import org.chromium.base.annotations.SuppressFBWarnings;

import org.chromium.base.library_loader.ProcessInitException;

import org.chromium.chrome.R;

import org.chromium.chrome.browser.ChromeApplication;

-import org.chromium.chrome.browser.feedback.FeedbackCollector;

import org.chromium.chrome.browser.help.HelpAndFeedback;

import org.chromium.chrome.browser.profiles.Profile;

@@ -234,7 +233,7 @@ public class Preferences extends AppCompatActivity implements

return true;

} else if (item.getItemId() == R.id.menu_id_help_general) {

HelpAndFeedback.getInstance(this).show(this, getString(R.string.help_context_settings),

- FeedbackCollector.create(Profile.getLastUsedProfile(), null));

+ Profile.getLastUsedProfile(), null);

return true;

}

return super.onOptionsItemSelected(item);