chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPage.java - Issue 1222453002: [Feedback] Use callbacks for FeedbackCollector and use ScreenshotTask

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPage.java

Issue 1222453002: [Feedback] Use callbacks for FeedbackCollector and use ScreenshotTask (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@add-feedback-collector-test

Patch Set: Squashed branch Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/help/HelpAndFeedback.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/preferences/LearnMorePreference.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPage.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPage.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPage.java

index 06f386a6b9e782ea32d6e3a921626047b2c5d342..03e5281e054cb0ce7a4c20110a719c94a2f52f5d 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPage.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPage.java

@@ -14,7 +14,6 @@ import org.chromium.chrome.R;

import org.chromium.chrome.browser.NativePage;

import org.chromium.chrome.browser.UrlConstants;

import org.chromium.chrome.browser.compositor.layouts.content.InvalidationAwareThumbnailProvider;

-import org.chromium.chrome.browser.feedback.FeedbackCollector;

import org.chromium.chrome.browser.help.HelpAndFeedback;

import org.chromium.chrome.browser.ntp.IncognitoNewTabPageView.IncognitoNewTabPageManager;

import org.chromium.chrome.browser.profiles.Profile;

@@ -37,7 +36,7 @@ public class IncognitoNewTabPage implements NativePage, InvalidationAwareThumbna

public void loadIncognitoLearnMore() {

HelpAndFeedback.getInstance(mActivity).show(mActivity,

mActivity.getString(R.string.help_context_incognito_learn_more),

- FeedbackCollector.create(Profile.getLastUsedProfile(), null));

+ Profile.getLastUsedProfile(), null);

}

@Override