chrome/android/java/src/org/chromium/chrome/browser/preferences/website/TranslatePreferences.java - Issue 1222453002: [Feedback] Use callbacks for FeedbackCollector and use ScreenshotTask

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/website/TranslatePreferences.java

Issue 1222453002: [Feedback] Use callbacks for FeedbackCollector and use ScreenshotTask (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@add-feedback-collector-test

Patch Set: Squashed branch Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferences.java ('k') | chrome/android/javatests_shell/src/org/chromium/chrome/browser/feedback/FeedbackCollectorTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/website/TranslatePreferences.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/TranslatePreferences.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/TranslatePreferences.java

index 411b12f182ded5c264499dd388e9e34bc768b325..57ac5a3db8f2ac1596b3daad8b7d5f2c833ebfb5 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/TranslatePreferences.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/TranslatePreferences.java

@@ -16,7 +16,6 @@ import android.view.MenuItem;

import android.widget.Toast;

import org.chromium.chrome.R;

-import org.chromium.chrome.browser.feedback.FeedbackCollector;

import org.chromium.chrome.browser.help.HelpAndFeedback;

import org.chromium.chrome.browser.preferences.ButtonPreference;

import org.chromium.chrome.browser.preferences.ChromeSwitchPreference;

@@ -92,7 +91,7 @@ public class TranslatePreferences extends PreferenceFragment {

if (itemId == R.id.menu_id_translate_help) {

HelpAndFeedback.getInstance(getActivity())

.show(getActivity(), getString(R.string.help_context_translate),

- FeedbackCollector.create(Profile.getLastUsedProfile(), null));

+ Profile.getLastUsedProfile(), null);

return true;

}

return false;