chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferences.java - Issue 1222453002: [Feedback] Use callbacks for FeedbackCollector and use ScreenshotTask

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferences.java

Issue 1222453002: [Feedback] Use callbacks for FeedbackCollector and use ScreenshotTask (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@add-feedback-collector-test

Patch Set: Squashed branch Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/preferences/Preferences.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/preferences/website/TranslatePreferences.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferences.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferences.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferences.java

index 650942d16360392ce8c0f3d4084952f8aa818d73..ef88aa16f6a952b8775b157e3f057da849e10ac1 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferences.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferences.java

@@ -17,7 +17,6 @@ import android.view.MenuItem;

import org.chromium.chrome.R;

import org.chromium.chrome.browser.contextualsearch.ContextualSearchFieldTrial;

-import org.chromium.chrome.browser.feedback.FeedbackCollector;

import org.chromium.chrome.browser.help.HelpAndFeedback;

import org.chromium.chrome.browser.precache.PrecacheLauncher;

import org.chromium.chrome.browser.preferences.ButtonPreference;

@@ -281,7 +280,7 @@ public class PrivacyPreferences extends PreferenceFragment

if (item.getItemId() == R.id.menu_id_help_privacy) {

HelpAndFeedback.getInstance(getActivity())

.show(getActivity(), getString(R.string.help_context_privacy),

- FeedbackCollector.create(Profile.getLastUsedProfile(), null));

+ Profile.getLastUsedProfile(), null);

return true;

}

return false;