Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1218593002: Move sky/examples to sky/sdk/lib/example, and code changes to support that change. Fixes T277. (Closed)

Created:
5 years, 6 months ago by iansf
Modified:
5 years, 5 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Move sky/examples to sky/sdk/lib/example, and code changes to support that change. Fixes T277. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/3efaef01848858ee42ee894834e6326d265f2810

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+-104 lines, -65473 lines) Patch
M sky/apk/stocks/org/domokit/stocks/StocksActivity.java View 1 chunk +1 line, -1 line 0 comments Download
D sky/examples/README.md View 1 chunk +0 lines, -16 lines 0 comments Download
D sky/examples/color/color-chooser.sky View 1 chunk +0 lines, -96 lines 0 comments Download
D sky/examples/color/color-wheel.png View Binary file 0 comments Download
D sky/examples/color/pubspec.yaml View 1 chunk +0 lines, -3 lines 0 comments Download
D sky/examples/game/lib/game_demo.dart View 1 chunk +0 lines, -10 lines 0 comments Download
D sky/examples/game/lib/game_demo_world.dart View 1 chunk +0 lines, -463 lines 0 comments Download
D sky/examples/game/lib/image_map.dart View 1 chunk +0 lines, -37 lines 0 comments Download
D sky/examples/game/lib/node.dart View 1 chunk +0 lines, -530 lines 0 comments Download
D sky/examples/game/lib/node_with_size.dart View 1 chunk +0 lines, -60 lines 0 comments Download
D sky/examples/game/lib/sprite.dart View 1 chunk +0 lines, -129 lines 0 comments Download
D sky/examples/game/lib/sprite_box.dart View 1 chunk +0 lines, -381 lines 0 comments Download
D sky/examples/game/lib/sprite_widget.dart View 1 chunk +0 lines, -38 lines 0 comments Download
D sky/examples/game/lib/sprites.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D sky/examples/game/lib/spritesheet.dart View 1 chunk +0 lines, -74 lines 0 comments Download
D sky/examples/game/lib/texture.dart View 1 chunk +0 lines, -73 lines 0 comments Download
D sky/examples/game/main.dart View 1 chunk +0 lines, -58 lines 0 comments Download
D sky/examples/game/pubspec.yaml View 1 chunk +0 lines, -3 lines 0 comments Download
D sky/examples/game/res/nebula.png View Binary file 0 comments Download
D sky/examples/game/res/sprites.json View 1 chunk +0 lines, -165 lines 0 comments Download
D sky/examples/game/res/sprites.png View Binary file 0 comments Download
D sky/examples/hello_world/hello_world.dart View 1 chunk +0 lines, -11 lines 0 comments Download
D sky/examples/hello_world/main.sky View 1 chunk +0 lines, -7 lines 0 comments Download
D sky/examples/hello_world/pubspec.yaml View 1 chunk +0 lines, -3 lines 0 comments Download
D sky/examples/lib/solid_color_box.dart View 1 chunk +0 lines, -51 lines 0 comments Download
D sky/examples/mine_digger/mine_digger.dart View 1 chunk +0 lines, -373 lines 0 comments Download
D sky/examples/raw/baseline.dart View 1 chunk +0 lines, -65 lines 0 comments Download
D sky/examples/raw/hello_world.dart View 1 chunk +0 lines, -48 lines 0 comments Download
D sky/examples/raw/launcher.dart View 1 chunk +0 lines, -58 lines 0 comments Download
D sky/examples/raw/painting.dart View 1 chunk +0 lines, -92 lines 0 comments Download
D sky/examples/raw/pubspec.yaml View 1 chunk +0 lines, -3 lines 0 comments Download
D sky/examples/raw/shadow.dart View 1 chunk +0 lines, -40 lines 0 comments Download
D sky/examples/raw/spinning_arabic.dart View 1 chunk +0 lines, -48 lines 0 comments Download
D sky/examples/raw/spinning_image.dart View 1 chunk +0 lines, -73 lines 0 comments Download
D sky/examples/raw/spinning_square.dart View 1 chunk +0 lines, -29 lines 0 comments Download
D sky/examples/raw/touch-demo.sky View 1 chunk +0 lines, -70 lines 0 comments Download
D sky/examples/rendering/baseline.dart View 1 chunk +0 lines, -78 lines 0 comments Download
D sky/examples/rendering/borders.dart View 1 chunk +0 lines, -77 lines 0 comments Download
D sky/examples/rendering/interactive_flex.dart View 1 chunk +0 lines, -101 lines 0 comments Download
D sky/examples/rendering/justify_content.dart View 1 chunk +0 lines, -46 lines 0 comments Download
D sky/examples/rendering/render_paragraph.dart View 1 chunk +0 lines, -46 lines 0 comments Download
D sky/examples/rendering/sector_layout.dart View 1 chunk +0 lines, -540 lines 0 comments Download
D sky/examples/rendering/shadowed_box.dart View 1 chunk +0 lines, -30 lines 0 comments Download
D sky/examples/rendering/spinning_flex.dart View 1 chunk +0 lines, -50 lines 0 comments Download
D sky/examples/rendering/touch_demo.dart View 1 chunk +0 lines, -91 lines 0 comments Download
D sky/examples/rendering/transform.dart View 1 chunk +0 lines, -29 lines 0 comments Download
D sky/examples/stocks/README.md View 1 chunk +0 lines, -31 lines 0 comments Download
D sky/examples/stocks/data/stock_data_0.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks/data/stock_data_1.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks/data/stock_data_10.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks/data/stock_data_11.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks/data/stock_data_12.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks/data/stock_data_13.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks/data/stock_data_14.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks/data/stock_data_15.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks/data/stock_data_16.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks/data/stock_data_17.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks/data/stock_data_18.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks/data/stock_data_19.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks/data/stock_data_2.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks/data/stock_data_20.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks/data/stock_data_21.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks/data/stock_data_22.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks/data/stock_data_23.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks/data/stock_data_24.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks/data/stock_data_25.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks/data/stock_data_26.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks/data/stock_data_27.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks/data/stock_data_28.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks/data/stock_data_29.json View 1 chunk +0 lines, -632 lines 0 comments Download
D sky/examples/stocks/data/stock_data_3.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks/data/stock_data_4.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks/data/stock_data_5.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks/data/stock_data_6.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks/data/stock_data_7.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks/data/stock_data_8.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks/data/stock_data_9.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks/lib/stock_app.dart View 1 chunk +0 lines, -225 lines 0 comments Download
D sky/examples/stocks/lib/stock_arrow.dart View 1 chunk +0 lines, -93 lines 0 comments Download
D sky/examples/stocks/lib/stock_data.dart View 1 chunk +0 lines, -72 lines 0 comments Download
D sky/examples/stocks/lib/stock_list.dart View 1 chunk +0 lines, -32 lines 0 comments Download
D sky/examples/stocks/lib/stock_menu.dart View 1 chunk +0 lines, -44 lines 0 comments Download
D sky/examples/stocks/lib/stock_row.dart View 1 chunk +0 lines, -72 lines 0 comments Download
D sky/examples/stocks/main.sky View 1 chunk +0 lines, -15 lines 0 comments Download
D sky/examples/stocks/pubspec.yaml View 1 chunk +0 lines, -7 lines 0 comments Download
D sky/examples/stocks2/README.md View 1 chunk +0 lines, -4 lines 0 comments Download
D sky/examples/stocks2/data/stock_data_0.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks2/data/stock_data_1.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks2/data/stock_data_10.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks2/data/stock_data_11.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks2/data/stock_data_12.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks2/data/stock_data_13.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks2/data/stock_data_14.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks2/data/stock_data_15.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks2/data/stock_data_16.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks2/data/stock_data_17.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks2/data/stock_data_18.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks2/data/stock_data_19.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks2/data/stock_data_2.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks2/data/stock_data_20.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks2/data/stock_data_21.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks2/data/stock_data_22.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks2/data/stock_data_23.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks2/data/stock_data_24.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks2/data/stock_data_25.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks2/data/stock_data_26.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks2/data/stock_data_27.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks2/data/stock_data_28.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks2/data/stock_data_29.json View 1 chunk +0 lines, -632 lines 0 comments Download
D sky/examples/stocks2/data/stock_data_3.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks2/data/stock_data_4.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks2/data/stock_data_5.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks2/data/stock_data_6.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks2/data/stock_data_7.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks2/data/stock_data_8.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks2/data/stock_data_9.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks2/lib/stock_app.dart View 1 chunk +0 lines, -82 lines 0 comments Download
D sky/examples/stocks2/lib/stock_arrow.dart View 1 chunk +0 lines, -75 lines 0 comments Download
D sky/examples/stocks2/lib/stock_data.dart View 1 chunk +0 lines, -73 lines 0 comments Download
D sky/examples/stocks2/lib/stock_home.dart View 1 chunk +0 lines, -221 lines 0 comments Download
D sky/examples/stocks2/lib/stock_list.dart View 1 chunk +0 lines, -40 lines 0 comments Download
D sky/examples/stocks2/lib/stock_menu.dart View 1 chunk +0 lines, -43 lines 0 comments Download
D sky/examples/stocks2/lib/stock_row.dart View 1 chunk +0 lines, -63 lines 0 comments Download
D sky/examples/stocks2/lib/stock_settings.dart View 1 chunk +0 lines, -116 lines 0 comments Download
D sky/examples/stocks2/lib/stock_types.dart View 1 chunk +0 lines, -1 line 0 comments Download
D sky/examples/stocks2/pubspec.yaml View 1 chunk +0 lines, -7 lines 0 comments Download
D sky/examples/widgets/container.dart View 1 chunk +0 lines, -51 lines 0 comments Download
D sky/examples/widgets/hello_widgets.dart View 1 chunk +0 lines, -15 lines 0 comments Download
D sky/examples/widgets/navigation.dart View 1 chunk +0 lines, -72 lines 0 comments Download
D sky/examples/widgets/sector.dart View 1 chunk +0 lines, -148 lines 0 comments Download
D sky/examples/widgets/spinning_mixed.dart View 1 chunk +0 lines, -100 lines 0 comments Download
D sky/examples/widgets/styled_text.dart View 1 chunk +0 lines, -127 lines 0 comments Download
D sky/examples/widgets/tabs.dart View 1 chunk +0 lines, -62 lines 0 comments Download
D sky/home.dart View 1 chunk +0 lines, -87 lines 0 comments Download
M sky/sdk/README.md View 2 chunks +2 lines, -2 lines 1 comment Download
A + sky/sdk/home.dart View 1 chunk +9 lines, -9 lines 0 comments Download
A + sky/sdk/lib/example/README.md View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/color/color-chooser.sky View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/color/color-wheel.png View Binary file 0 comments Download
A + sky/sdk/lib/example/color/pubspec.yaml View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/game/lib/game_demo.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/game/lib/game_demo_world.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/game/lib/image_map.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/game/lib/node.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/game/lib/node_with_size.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/game/lib/sprite.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/game/lib/sprite_box.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/game/lib/sprite_widget.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/game/lib/sprites.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/game/lib/spritesheet.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/game/lib/texture.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/game/main.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/game/pubspec.yaml View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/game/res/nebula.png View Binary file 0 comments Download
A + sky/sdk/lib/example/game/res/sprites.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/game/res/sprites.png View Binary file 0 comments Download
A + sky/sdk/lib/example/hello_world/hello_world.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/hello_world/main.sky View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/hello_world/pubspec.yaml View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/lib/solid_color_box.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/mine_digger/mine_digger.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/raw/baseline.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/raw/hello_world.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/raw/launcher.dart View 1 chunk +1 line, -1 line 0 comments Download
A + sky/sdk/lib/example/raw/painting.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/raw/pubspec.yaml View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/raw/shadow.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/raw/spinning_arabic.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/raw/spinning_image.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/raw/spinning_square.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/raw/touch-demo.sky View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/rendering/baseline.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/rendering/borders.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/rendering/interactive_flex.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/rendering/justify_content.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/rendering/render_paragraph.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/rendering/sector_layout.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/rendering/shadowed_box.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/rendering/spinning_flex.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/rendering/touch_demo.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/rendering/transform.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks/README.md View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks/data/stock_data_0.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks/data/stock_data_1.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks/data/stock_data_10.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks/data/stock_data_11.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks/data/stock_data_12.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks/data/stock_data_13.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks/data/stock_data_14.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks/data/stock_data_15.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks/data/stock_data_16.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks/data/stock_data_17.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks/data/stock_data_18.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks/data/stock_data_19.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks/data/stock_data_2.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks/data/stock_data_20.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks/data/stock_data_21.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks/data/stock_data_22.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks/data/stock_data_23.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks/data/stock_data_24.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks/data/stock_data_25.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks/data/stock_data_26.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks/data/stock_data_27.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks/data/stock_data_28.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks/data/stock_data_29.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks/data/stock_data_3.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks/data/stock_data_4.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks/data/stock_data_5.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks/data/stock_data_6.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks/data/stock_data_7.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks/data/stock_data_8.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks/data/stock_data_9.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks/lib/stock_app.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks/lib/stock_arrow.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks/lib/stock_data.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks/lib/stock_list.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks/lib/stock_menu.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks/lib/stock_row.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks/main.sky View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
A + sky/sdk/lib/example/stocks2/README.md View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks2/data/stock_data_0.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks2/data/stock_data_1.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks2/data/stock_data_10.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks2/data/stock_data_11.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks2/data/stock_data_12.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks2/data/stock_data_13.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks2/data/stock_data_14.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks2/data/stock_data_15.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks2/data/stock_data_16.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks2/data/stock_data_17.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks2/data/stock_data_18.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks2/data/stock_data_19.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks2/data/stock_data_2.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks2/data/stock_data_20.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks2/data/stock_data_21.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks2/data/stock_data_22.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks2/data/stock_data_23.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks2/data/stock_data_24.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks2/data/stock_data_25.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks2/data/stock_data_26.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks2/data/stock_data_27.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks2/data/stock_data_28.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks2/data/stock_data_29.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks2/data/stock_data_3.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks2/data/stock_data_4.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks2/data/stock_data_5.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks2/data/stock_data_6.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks2/data/stock_data_7.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks2/data/stock_data_8.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks2/data/stock_data_9.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks2/lib/stock_app.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks2/lib/stock_arrow.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks2/lib/stock_data.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks2/lib/stock_home.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks2/lib/stock_list.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks2/lib/stock_menu.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks2/lib/stock_row.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks2/lib/stock_settings.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks2/lib/stock_types.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/stocks2/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
A + sky/sdk/lib/example/widgets/container.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/widgets/hello_widgets.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/widgets/navigation.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/widgets/sector.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/widgets/spinning_mixed.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/widgets/styled_text.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/example/widgets/tabs.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
M sky/sdk/lib/rendering/README.md View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/examples/sector.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/examples/stocks.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/examples/styled_text.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/examples/tabs.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/raw/sector_layout.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/tools/deploy_sdk.py View 1 chunk +0 lines, -1 line 0 comments Download
M sky/tools/webkitpy/layout_tests/run_webkit_tests.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
iansf
5 years, 6 months ago (2015-06-26 21:46:18 UTC) #1
abarth-chromium
lgtm https://codereview.chromium.org/1218593002/diff/1/sky/sdk/README.md File sky/sdk/README.md (right): https://codereview.chromium.org/1218593002/diff/1/sky/sdk/README.md#newcode91 sky/sdk/README.md:91: * To dive into examples, please see the ...
5 years, 6 months ago (2015-06-26 21:56:40 UTC) #2
iansf
Committed patchset #1 (id:1) manually as 3efaef01848858ee42ee894834e6326d265f2810 (presubmit successful).
5 years, 6 months ago (2015-06-26 22:06:50 UTC) #3
abarth-chromium
I'm sorry, but I didn't do a good job reviewing this CL. The |example| folder ...
5 years, 5 months ago (2015-06-27 05:44:24 UTC) #4
abarth-chromium
5 years, 5 months ago (2015-06-27 05:51:37 UTC) #5
Message was sent while issue was closed. 
Using your CL as a template, I created
https://codereview.chromium.org/1210173004 to move the example directory up one
level.  Sorry for the poor reviewing on my part.  :(

Powered by Google App Engine
This is Rietveld 408576698