Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 1217813005: [Telemetry] Modify CreatePageSet to CreateStorySet (Closed)

Created:
5 years, 5 months ago by nednguyen
Modified:
5 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org, telemetry-reviews_chromium.org, rmistry
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Modify CreatePageSet to CreateStorySet BUG=465594 Committed: https://crrev.com/8af27d5cf40ebe4590fd5cc65880c9ab8b632ba4 Cr-Commit-Position: refs/heads/master@{#336713}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Address Ethan's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -93 lines) Patch
M content/test/gpu/gpu_tests/context_lost.py View 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu/gpu_tests/gpu_process.py View 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu/gpu_tests/gpu_rasterization.py View 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu/gpu_tests/hardware_accelerated_feature.py View 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu/gpu_tests/maps.py View 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu/gpu_tests/memory_test.py View 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu/gpu_tests/pixel.py View 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu/gpu_tests/screenshot_sync.py View 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu/gpu_tests/trace_test.py View 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu/gpu_tests/webgl_robustness.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/benchmarks/benchmark_smoke_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/benchmarks/blink_perf.py View 13 chunks +25 lines, -25 lines 0 comments Download
M tools/perf/benchmarks/dom_perf.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/benchmarks/dromaeo.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/benchmarks/inbox_benchmark.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/benchmarks/indexeddb_perf.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/benchmarks/jetstream.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/benchmarks/kraken.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/benchmarks/maps.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/benchmarks/octane.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/benchmarks/oilpan_gc_times.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/benchmarks/page_cycler.py View 3 chunks +3 lines, -3 lines 0 comments Download
M tools/perf/benchmarks/rasterize_and_record_micro.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/benchmarks/robohornet_pro.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/benchmarks/session_restore.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/benchmarks/skpicture_printer.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/benchmarks/spaceport.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/benchmarks/speedometer.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/benchmarks/sunspider.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/benchmarks/tab_switching.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/measurements/blink_style_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/measurements/oilpan_gc_times_unittest.py View 2 chunks +4 lines, -2 lines 0 comments Download
M tools/perf/measurements/rasterize_and_record_micro_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/measurements/skpicture_printer_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/measurements/smoothness_unittest.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/measurements/thread_times_unittest.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/benchmark.py View 2 chunks +6 lines, -14 lines 0 comments Download
M tools/telemetry/telemetry/internal/util/find_dependencies.py View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/page/page_test_unittest.py View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/record_wpr.py View 1 2 chunks +3 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/record_wpr_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/unittest_util/page_test_test_case.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1217813005/1
5 years, 5 months ago (2015-06-29 19:20:57 UTC) #2
nednguyen
5 years, 5 months ago (2015-06-29 19:21:03 UTC) #4
eakuefner
lgtm I'm wondering whether we want to care about references to "page set" in comments/variable ...
5 years, 5 months ago (2015-06-29 19:24:42 UTC) #5
nednguyen
https://codereview.chromium.org/1217813005/diff/1/tools/telemetry/telemetry/record_wpr.py File tools/telemetry/telemetry/record_wpr.py (right): https://codereview.chromium.org/1217813005/diff/1/tools/telemetry/telemetry/record_wpr.py#newcode165 tools/telemetry/telemetry/record_wpr.py:165: def _GetPageSet(self, base_dir, target): On 2015/06/29 19:24:42, eakuefner wrote: ...
5 years, 5 months ago (2015-06-29 20:25:02 UTC) #7
Ken Russell (switch to Gerrit)
content/test/gpu LGTM as long as it passes the trybots.
5 years, 5 months ago (2015-06-29 22:57:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1217813005/20001
5 years, 5 months ago (2015-06-29 23:08:18 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1217813005/20001
5 years, 5 months ago (2015-06-30 01:51:33 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-06-30 01:58:46 UTC) #15
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/8af27d5cf40ebe4590fd5cc65880c9ab8b632ba4 Cr-Commit-Position: refs/heads/master@{#336713}
5 years, 5 months ago (2015-06-30 01:59:38 UTC) #16
Rick Byers
5 years, 5 months ago (2015-06-30 18:45:12 UTC) #17
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1217653003/ by rbyers@chromium.org.

The reason for reverting is: Speculative revert to attempt to address extreme
long-running telemetry jobs.  See http://crbug.com/505867 for details..

Powered by Google App Engine
This is Rietveld 408576698