Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/perf/benchmarks/page_cycler.py

Issue 1217813005: [Telemetry] Modify CreatePageSet to CreateStorySet (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address Ethan's comments Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/benchmarks/oilpan_gc_times.py ('k') | tools/perf/benchmarks/rasterize_and_record_micro.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/page_cycler.py
diff --git a/tools/perf/benchmarks/page_cycler.py b/tools/perf/benchmarks/page_cycler.py
index 7cd924b4bcd9eb2b5737134add88d6df48c2378a..94d54f6f803ef5b63d94be2c70309bb0d25c26e7 100644
--- a/tools/perf/benchmarks/page_cycler.py
+++ b/tools/perf/benchmarks/page_cycler.py
@@ -174,7 +174,7 @@ class PageCyclerTop10Mobile(_PageCycler):
def Name(cls):
return 'page_cycler.top_10_mobile'
- def CreatePageSet(self, options):
+ def CreateStorySet(self, options):
return page_sets.Top10MobilePageSet(run_no_page_interactions=True)
@@ -214,7 +214,7 @@ class PageCyclerTypical25(_PageCycler):
def Name(cls):
return 'page_cycler.typical_25'
- def CreatePageSet(self, options):
+ def CreateStorySet(self, options):
return page_sets.Typical25PageSet(run_no_page_interactions=True)
# crbug.com/273986: This test is flakey on Windows.
@@ -230,7 +230,7 @@ class PageCyclerOopifTypical25(_PageCycler):
def SetExtraBrowserOptions(self, options):
options.AppendExtraBrowserArgs(['--site-per-process'])
- def CreatePageSet(self, options):
+ def CreateStorySet(self, options):
return page_sets.Typical25PageSet(run_no_page_interactions=True)
« no previous file with comments | « tools/perf/benchmarks/oilpan_gc_times.py ('k') | tools/perf/benchmarks/rasterize_and_record_micro.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698