tools/telemetry/telemetry/record_wpr_unittest.py - Issue 1217813005: [Telemetry] Modify CreatePageSet to CreateStorySet

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/record_wpr_unittest.py

Issue 1217813005: [Telemetry] Modify CreatePageSet to CreateStorySet (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Ethan's comments Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/telemetry/telemetry/record_wpr_unittest.py

diff --git a/tools/telemetry/telemetry/record_wpr_unittest.py b/tools/telemetry/telemetry/record_wpr_unittest.py

index d78bba03671b7c56b13a1b51080e8848746f5773..501931b62395425e61889ecbf86f56f6e6db14c7 100644

--- a/tools/telemetry/telemetry/record_wpr_unittest.py

+++ b/tools/telemetry/telemetry/record_wpr_unittest.py

@@ -72,7 +72,7 @@ class MockBenchmark(benchmark.Benchmark):

def AddBenchmarkCommandLineArgs(cls, group):

group.add_option('', '--mock-benchmark-url', action='store', type='string')

- def CreatePageSet(self, options):

+ def CreateStorySet(self, options):

kwargs = {}

if options.mock_benchmark_url:

kwargs['url'] = options.mock_benchmark_url