Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Unified Diff: tools/telemetry/telemetry/unittest_util/page_test_test_case.py

Issue 1217813005: [Telemetry] Modify CreatePageSet to CreateStorySet (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address Ethan's comments Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/record_wpr_unittest.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/unittest_util/page_test_test_case.py
diff --git a/tools/telemetry/telemetry/unittest_util/page_test_test_case.py b/tools/telemetry/telemetry/unittest_util/page_test_test_case.py
index 9634f31473e0c13913e704160abf8568c63264da..c4b3b1ed75798d445e97ecb4bdd83f898debd572 100644
--- a/tools/telemetry/telemetry/unittest_util/page_test_test_case.py
+++ b/tools/telemetry/telemetry/unittest_util/page_test_test_case.py
@@ -35,7 +35,7 @@ class EmptyMetadataForTest(benchmark.BenchmarkMetadata):
class PageTestTestCase(unittest.TestCase):
"""A base class to simplify writing unit tests for PageTest subclasses."""
- def CreatePageSetFromFileInUnittestDataDir(self, test_filename):
+ def CreateStorySetFromFileInUnittestDataDir(self, test_filename):
ps = self.CreateEmptyPageSet()
page = BasicTestPage('file://' + test_filename, ps, base_dir=ps.base_dir)
ps.AddUserStory(page)
@@ -72,7 +72,7 @@ class PageTestTestCase(unittest.TestCase):
return results
def TestTracingCleanedUp(self, measurement_class, options=None):
- ps = self.CreatePageSetFromFileInUnittestDataDir('blank.html')
+ ps = self.CreateStorySetFromFileInUnittestDataDir('blank.html')
start_tracing_called = [False]
stop_tracing_called = [False]
« no previous file with comments | « tools/telemetry/telemetry/record_wpr_unittest.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698