tools/perf/benchmarks/benchmark_smoke_unittest.py - Issue 1217813005: [Telemetry] Modify CreatePageSet to CreateStorySet

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/benchmarks/benchmark_smoke_unittest.py

Issue 1217813005: [Telemetry] Modify CreatePageSet to CreateStorySet (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Ethan's comments Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/benchmarks/benchmark_smoke_unittest.py

diff --git a/tools/perf/benchmarks/benchmark_smoke_unittest.py b/tools/perf/benchmarks/benchmark_smoke_unittest.py

index 209e658badaa03b38f537c0784883d98da6297db..767934f94fa2053ca61b069fc53574d0e910a7b9 100644

--- a/tools/perf/benchmarks/benchmark_smoke_unittest.py

+++ b/tools/perf/benchmarks/benchmark_smoke_unittest.py

@@ -46,9 +46,9 @@ def SmokeTestGenerator(benchmark):

benchmark.options['page_repeat'] = 1

class SinglePageBenchmark(benchmark): # pylint: disable=W0232

- def CreatePageSet(self, options):

+ def CreateStorySet(self, options):

# pylint: disable=E1002

- ps = super(SinglePageBenchmark, self).CreatePageSet(options)

+ ps = super(SinglePageBenchmark, self).CreateStorySet(options)

for p in ps.pages:

p.skip_waits = True

ps.user_stories = [p]

« no previous file with comments | « content/test/gpu/gpu_tests/webgl_robustness.py ('k') | tools/perf/benchmarks/blink_perf.py » ('j') | no next file with comments »