tools/perf/measurements/oilpan_gc_times_unittest.py - Issue 1217813005: [Telemetry] Modify CreatePageSet to CreateStorySet

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/measurements/oilpan_gc_times_unittest.py

Issue 1217813005: [Telemetry] Modify CreatePageSet to CreateStorySet (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Ethan's comments Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/measurements/oilpan_gc_times_unittest.py

diff --git a/tools/perf/measurements/oilpan_gc_times_unittest.py b/tools/perf/measurements/oilpan_gc_times_unittest.py

index dc32f6218523ab5f01aba3ce2c5dab356d03d733..529cfddf6868eea5e552ede1353dce8fe459def0 100644

--- a/tools/perf/measurements/oilpan_gc_times_unittest.py

+++ b/tools/perf/measurements/oilpan_gc_times_unittest.py

@@ -156,7 +156,8 @@ class OilpanGCTimesTest(page_test_test_case.PageTestTestCase):

'oilpan_idle_complete_sweep')))

def testForSmoothness(self):

- ps = self.CreatePageSetFromFileInUnittestDataDir('create_many_objects.html')

+ ps = self.CreateStorySetFromFileInUnittestDataDir(

+ 'create_many_objects.html')

measurement = oilpan_gc_times.OilpanGCTimesForSmoothness()

results = self.RunMeasurement(measurement, ps, options=self._options)

self.assertEquals(0, len(results.failures))

@@ -167,7 +168,8 @@ class OilpanGCTimesTest(page_test_test_case.PageTestTestCase):

self.assertLess(0, len(precise) + len(conservative))

def testForBlinkPerf(self):

- ps = self.CreatePageSetFromFileInUnittestDataDir('create_many_objects.html')

+ ps = self.CreateStorySetFromFileInUnittestDataDir(

+ 'create_many_objects.html')

measurement = oilpan_gc_times.OilpanGCTimesForBlinkPerf()

results = self.RunMeasurement(measurement, ps, options=self._options)

self.assertEquals(0, len(results.failures))