Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 1215653003: Remove the notifyFailedSignedIn callback from Chromium. (Closed)

Created:
5 years, 6 months ago by msramek
Modified:
5 years, 5 months ago
Reviewers:
Mike West
CC:
chromium-reviews, darin-cc_chromium.org, gcasto+watchlist_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mkwst+watchlist-passwords_chromium.org, mlamouri+watch-content_chromium.org, vabr+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the notifyFailedSignedIn callback from Chromium. As this is not a part of the specification https://w3c.github.io/webappsec/specs/credentialmanagement/#credentialcontainer Also remove the associated acknowledgeFailedSignIn messages. This patch is a part of a two-sided patchset: Blink: https://codereview.chromium.org/1217463002/ Chromium: https://codereview.chromium.org/1215653003/ <-- this patch BUG=494880 Committed: https://crrev.com/94c6e97308ce39079a3f5213db4acefbf6eaac9b Cr-Commit-Position: refs/heads/master@{#337208}

Patch Set 1 #

Patch Set 2 : MockCredentialManagerClient #

Patch Set 3 : components_browsertests #

Messages

Total messages: 14 (6 generated)
msramek
...and the second part. If I understand correctly, there should be no third part, since ...
5 years, 5 months ago (2015-06-29 09:20:13 UTC) #2
Mike West
Implementation and dropping the IPC LGTM. Thanks!
5 years, 5 months ago (2015-06-29 09:29:37 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1215653003/1
5 years, 5 months ago (2015-06-30 09:23:00 UTC) #5
commit-bot: I haz the power
Dry run: Exceeded global retry quota
5 years, 5 months ago (2015-06-30 09:33:24 UTC) #7
msramek
Forgot about one occurrence.
5 years, 5 months ago (2015-06-30 11:57:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1215653003/60001
5 years, 5 months ago (2015-07-02 11:21:08 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 5 months ago (2015-07-02 12:41:56 UTC) #13
commit-bot: I haz the power
5 years, 5 months ago (2015-07-02 12:43:01 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/94c6e97308ce39079a3f5213db4acefbf6eaac9b
Cr-Commit-Position: refs/heads/master@{#337208}

Powered by Google App Engine
This is Rietveld 408576698