Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Unified Diff: components/password_manager/content/renderer/credential_manager_client.cc

Issue 1215653003: Remove the notifyFailedSignedIn callback from Chromium. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: components_browsertests Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/content/renderer/credential_manager_client.cc
diff --git a/components/password_manager/content/renderer/credential_manager_client.cc b/components/password_manager/content/renderer/credential_manager_client.cc
index 03b17a09f5275d6f2de883d237575e3c9d41b3de..803082472c26405d7a7428dc0b6672cc9e80d1a9 100644
--- a/components/password_manager/content/renderer/credential_manager_client.cc
+++ b/components/password_manager/content/renderer/credential_manager_client.cc
@@ -51,8 +51,6 @@ CredentialManagerClient::~CredentialManagerClient() {
bool CredentialManagerClient::OnMessageReceived(const IPC::Message& message) {
bool handled = true;
IPC_BEGIN_MESSAGE_MAP(CredentialManagerClient, message)
- IPC_MESSAGE_HANDLER(CredentialManagerMsg_AcknowledgeFailedSignIn,
- OnAcknowledgeFailedSignIn)
IPC_MESSAGE_HANDLER(CredentialManagerMsg_AcknowledgeSignedIn,
OnAcknowledgeSignedIn)
IPC_MESSAGE_HANDLER(CredentialManagerMsg_AcknowledgeRequireUserMediation,
@@ -65,10 +63,6 @@ bool CredentialManagerClient::OnMessageReceived(const IPC::Message& message) {
return handled;
}
-void CredentialManagerClient::OnAcknowledgeFailedSignIn(int request_id) {
- RespondToNotificationCallback(request_id, &failed_sign_in_callbacks_);
-}
-
void CredentialManagerClient::OnAcknowledgeSignedIn(int request_id) {
RespondToNotificationCallback(request_id, &signed_in_callbacks_);
}
@@ -114,15 +108,6 @@ void CredentialManagerClient::OnRejectCredentialRequest(
// -----------------------------------------------------------------------------
// Dispatch messages from the renderer to the browser.
-void CredentialManagerClient::dispatchFailedSignIn(
- const blink::WebCredential& credential,
- blink::WebCredentialManagerClient::NotificationCallbacks* callbacks) {
- int request_id = failed_sign_in_callbacks_.Add(callbacks);
- CredentialInfo info(WebCredentialToCredentialInfo(credential));
- Send(new CredentialManagerHostMsg_NotifyFailedSignIn(
- routing_id(), request_id, info));
-}
-
void CredentialManagerClient::dispatchSignedIn(
const blink::WebCredential& credential,
blink::WebCredentialManagerClient::NotificationCallbacks* callbacks) {

Powered by Google App Engine
This is Rietveld 408576698