Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Unified Diff: components/password_manager/content/browser/credential_manager_dispatcher.cc

Issue 1215653003: Remove the notifyFailedSignedIn callback from Chromium. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: components_browsertests Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/content/browser/credential_manager_dispatcher.cc
diff --git a/components/password_manager/content/browser/credential_manager_dispatcher.cc b/components/password_manager/content/browser/credential_manager_dispatcher.cc
index 01e182ecfb354feaa1462c903f447fa025e17f83..ab48d621f6dfdb2a80a13b661d3cc056e1b07664 100644
--- a/components/password_manager/content/browser/credential_manager_dispatcher.cc
+++ b/components/password_manager/content/browser/credential_manager_dispatcher.cc
@@ -40,8 +40,6 @@ bool CredentialManagerDispatcher::OnMessageReceived(
const IPC::Message& message) {
bool handled = true;
IPC_BEGIN_MESSAGE_MAP(CredentialManagerDispatcher, message)
- IPC_MESSAGE_HANDLER(CredentialManagerHostMsg_NotifyFailedSignIn,
- OnNotifyFailedSignIn);
IPC_MESSAGE_HANDLER(CredentialManagerHostMsg_NotifySignedIn,
OnNotifySignedIn);
IPC_MESSAGE_HANDLER(CredentialManagerHostMsg_RequireUserMediation,
@@ -53,15 +51,6 @@ bool CredentialManagerDispatcher::OnMessageReceived(
return handled;
}
-void CredentialManagerDispatcher::OnNotifyFailedSignIn(int request_id,
- const CredentialInfo&) {
- DCHECK(request_id);
- // TODO(mkwst): This is a stub.
- web_contents()->GetRenderViewHost()->Send(
- new CredentialManagerMsg_AcknowledgeFailedSignIn(
- web_contents()->GetRenderViewHost()->GetRoutingID(), request_id));
-}
-
void CredentialManagerDispatcher::OnNotifySignedIn(
int request_id,
const password_manager::CredentialInfo& credential) {

Powered by Google App Engine
This is Rietveld 408576698