components/password_manager/content/renderer/credential_manager_client.h - Issue 1215653003: Remove the notifyFailedSignedIn callback from Chromium.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/content/renderer/credential_manager_client.h

Issue 1215653003: Remove the notifyFailedSignedIn callback from Chromium. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: components_browsertests Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/content/common/credential_manager_messages.h ('k') | components/password_manager/content/renderer/credential_manager_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/content/renderer/credential_manager_client.h

diff --git a/components/password_manager/content/renderer/credential_manager_client.h b/components/password_manager/content/renderer/credential_manager_client.h

index c854636d5761232a3371c4beee7f782e3d8e5821..8cd5119187c3e6af320cb7a459723ce3ef8a3b1c 100644

--- a/components/password_manager/content/renderer/credential_manager_client.h

+++ b/components/password_manager/content/renderer/credential_manager_client.h

@@ -54,7 +54,6 @@ class CredentialManagerClient : public blink::WebCredentialManagerClient,

bool OnMessageReceived(const IPC::Message& message) override;

// Message handlers for messages from the browser process:

- virtual void OnAcknowledgeFailedSignIn(int request_id);

virtual void OnAcknowledgeSignedIn(int request_id);

virtual void OnAcknowledgeRequireUserMediation(int request_id);

virtual void OnSendCredential(int request_id,

@@ -64,9 +63,6 @@ class CredentialManagerClient : public blink::WebCredentialManagerClient,

blink::WebCredentialManagerError::ErrorType error_type);

// blink::WebCredentialManager:

- virtual void dispatchFailedSignIn(

- const blink::WebCredential& credential,

- WebCredentialManagerClient::NotificationCallbacks* callbacks);

virtual void dispatchSignedIn(

const blink::WebCredential& credential,

WebCredentialManagerClient::NotificationCallbacks* callbacks);