components/password_manager/content/common/credential_manager_messages.h - Issue 1215653003: Remove the notifyFailedSignedIn callback from Chromium.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/content/common/credential_manager_messages.h

Issue 1215653003: Remove the notifyFailedSignedIn callback from Chromium. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: components_browsertests Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/content/browser/credential_manager_dispatcher_unittest.cc ('k') | components/password_manager/content/renderer/credential_manager_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/content/common/credential_manager_messages.h

diff --git a/components/password_manager/content/common/credential_manager_messages.h b/components/password_manager/content/common/credential_manager_messages.h

index 9cb485f58e83f8b2c17715fce906b44d2ea37bc8..52fd824421f8ddcf76926af3b8fd30884781a0f4 100644

--- a/components/password_manager/content/common/credential_manager_messages.h

+++ b/components/password_manager/content/common/credential_manager_messages.h

@@ -37,15 +37,6 @@ IPC_STRUCT_TRAITS_END()

// ----------------------------------------------------------------------------

// Messages sent from the renderer to the browser

-// Passes the notification from 'navigator.credentials.notifyFailedSignIn()' up

-// to the browser process in order to suppress the automatic bubble which would

-// pop up in order to prompt the user to save the credential she used for

-// signin. The browser process will respond with a

-// CredentialManagerMsg_AcknowledgeFailedSignedIn message.

-IPC_MESSAGE_ROUTED2(CredentialManagerHostMsg_NotifyFailedSignIn,

- int /* request_id */,

- password_manager::CredentialInfo /* credential */)

// Passes the notification from 'navigator.credentials.notifySignedIn()' up to

// the browser process in order to (among other things) prompt the user to save

// the credential she used for signin. The browser process will respond with a

@@ -73,11 +64,6 @@ IPC_MESSAGE_ROUTED3(CredentialManagerHostMsg_RequestCredential,

// Messages sent from the browser to the renderer

// Notify the renderer that the browser process has finished processing a

-// CredentialManagerHostMsg_NotifyFailedSignedIn message.

-IPC_MESSAGE_ROUTED1(CredentialManagerMsg_AcknowledgeFailedSignIn,

- int /* request_id */)

-// Notify the renderer that the browser process has finished processing a

// CredentialManagerHostMsg_NotifySignedIn message.

IPC_MESSAGE_ROUTED1(CredentialManagerMsg_AcknowledgeSignedIn,

int /* request_id */)