Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Unified Diff: components/password_manager/content/renderer/credential_manager_client_browsertest.cc

Issue 1215653003: Remove the notifyFailedSignedIn callback from Chromium. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: components_browsertests Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/content/renderer/credential_manager_client_browsertest.cc
diff --git a/components/password_manager/content/renderer/credential_manager_client_browsertest.cc b/components/password_manager/content/renderer/credential_manager_client_browsertest.cc
index 5095fd8d07f666bd12aa01624a976994a0a1d834..22071673fb995e768dddfaa5c4dfbddff8720d70 100644
--- a/components/password_manager/content/renderer/credential_manager_client_browsertest.cc
+++ b/components/password_manager/content/renderer/credential_manager_client_browsertest.cc
@@ -52,13 +52,6 @@ class CredentialManagerClientTest : public content::RenderViewTest {
return false;
switch (message_id) {
- case CredentialManagerHostMsg_NotifyFailedSignIn::ID: {
- base::Tuple<int, CredentialInfo> param;
- CredentialManagerHostMsg_NotifyFailedSignIn::Read(message, &param);
- request_id = base::get<0>(param);
- break;
- }
-
case CredentialManagerHostMsg_NotifySignedIn::ID: {
base::Tuple<int, CredentialInfo> param;
CredentialManagerHostMsg_NotifySignedIn::Read(message, &param);
@@ -146,23 +139,6 @@ class TestRequestCallbacks
} // namespace
-TEST_F(CredentialManagerClientTest, SendNotifyFailedSignIn) {
- int request_id;
- EXPECT_FALSE(ExtractRequestId(CredentialManagerHostMsg_NotifyFailedSignIn::ID,
- request_id));
-
- scoped_ptr<TestNotificationCallbacks> callbacks(
- new TestNotificationCallbacks(this));
- client_->dispatchFailedSignIn(*credential(), callbacks.release());
-
- EXPECT_TRUE(ExtractRequestId(CredentialManagerHostMsg_NotifyFailedSignIn::ID,
- request_id));
-
- client_->OnAcknowledgeFailedSignIn(request_id);
- EXPECT_TRUE(callback_succeeded());
- EXPECT_FALSE(callback_errored());
-}
-
TEST_F(CredentialManagerClientTest, SendNotifySignedIn) {
int request_id;
EXPECT_FALSE(ExtractRequestId(CredentialManagerHostMsg_NotifySignedIn::ID,

Powered by Google App Engine
This is Rietveld 408576698