Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1215643006: more threading of GrShaderDataManager (Closed)

Created:
5 years, 5 months ago by joshua.litt
Modified:
5 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@GrShaderDataManager3
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : tweaks #

Patch Set 3 : tweaks #

Total comments: 2

Patch Set 4 : tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -74 lines) Patch
M gm/dcshader.cpp View 1 2 3 2 chunks +4 lines, -3 lines 0 comments Download
M include/core/SkXfermode.h View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M include/gpu/effects/GrCustomXfermode.h View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M src/core/SkXfermode.cpp View 1 2 3 2 chunks +5 lines, -2 lines 0 comments Download
M src/core/SkXfermode_proccoeff.h View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M src/effects/SkAlphaThresholdFilter.cpp View 5 chunks +12 lines, -6 lines 0 comments Download
M src/effects/SkArithmeticMode.cpp View 1 2 3 2 chunks +5 lines, -2 lines 0 comments Download
M src/effects/SkArithmeticMode_gpu.h View 2 chunks +7 lines, -5 lines 0 comments Download
M src/effects/SkArithmeticMode_gpu.cpp View 1 2 3 2 chunks +4 lines, -2 lines 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 5 chunks +11 lines, -4 lines 0 comments Download
M src/effects/SkPerlinNoiseShader.cpp View 1 2 3 4 chunks +10 lines, -6 lines 0 comments Download
M src/effects/SkXfermodeImageFilter.cpp View 1 2 3 3 chunks +4 lines, -3 lines 0 comments Download
M src/effects/gradients/SkGradientShader.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/effects/gradients/SkGradientShaderPriv.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/effects/gradients/SkLinearGradient.cpp View 1 2 3 4 chunks +7 lines, -4 lines 0 comments Download
M src/effects/gradients/SkRadialGradient.cpp View 1 2 3 4 chunks +7 lines, -4 lines 0 comments Download
M src/effects/gradients/SkSweepGradient.cpp View 1 2 3 4 chunks +7 lines, -6 lines 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient.cpp View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient_gpu.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient_gpu.cpp View 1 2 3 13 chunks +37 lines, -16 lines 0 comments Download
M src/gpu/effects/GrCustomXfermode.cpp View 1 2 3 3 chunks +7 lines, -4 lines 0 comments Download
M src/gpu/effects/GrCustomXfermodePriv.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
joshualitt
ptal
5 years, 5 months ago (2015-07-08 15:58:08 UTC) #2
robertphillips
lgtm https://codereview.chromium.org/1215643006/diff/40001/src/effects/SkAlphaThresholdFilter.cpp File src/effects/SkAlphaThresholdFilter.cpp (right): https://codereview.chromium.org/1215643006/diff/40001/src/effects/SkAlphaThresholdFilter.cpp#newcode210 src/effects/SkAlphaThresholdFilter.cpp:210: GrFragmentProcessor* AlphaThresholdEffect::TestCreate(SkRandom* random, tab these over ? https://codereview.chromium.org/1215643006/diff/40001/src/effects/SkAlphaThresholdFilter.cpp#newcode217 ...
5 years, 5 months ago (2015-07-08 16:24:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1215643006/60001
5 years, 5 months ago (2015-07-08 16:29:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1215643006/60001
5 years, 5 months ago (2015-07-08 16:30:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1215643006/60001
5 years, 5 months ago (2015-07-08 16:30:45 UTC) #12
commit-bot: I haz the power
5 years, 5 months ago (2015-07-08 16:37:06 UTC) #13
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/b2456053c7e20e5439915cd2954c71f73bc85375

Powered by Google App Engine
This is Rietveld 408576698