|
[Autofill/Autocomplete Feature] Substring matching instead of prefix matching.
With present implementation autofill/autocomplete suggestions are matched for
prefix for what user has typed.
This patch brings in suggestions with substring matching (i.e. substring matching
to the beginning of suggestion tokens) instead of prefix matching.
Patch spread across chromium side as well as on Blink side.
[1] Blink side: https://codereview.chromium.org/1208063002/
- aims to cache the suggestion start index with |WebFormControlElement| so that
chromium content can make use of it on setting selection range.
[2] Chromium side: https://codereview.chromium.org/1208133002/ (This CL)
- aims to add IPC changes to introduce |match_start| for suggestion preview in
case of password manager and autocomplete so that additional calulation on
renderer to get selection range in not needed.
[3] Chromium side: https://codereview.chromium.org/962673004/
- Substring match instead of prefixes.
BUG= 77194
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+166 lines, -100 lines) |
Patch |
 |
M |
chrome/browser/ui/autofill/autofill_dialog_controller_impl.h
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/autofill/autofill_popup_controller_impl.cc
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/autofill/autofill_popup_controller_unittest.cc
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
chrome/renderer/autofill/password_autofill_agent_browsertest.cc
|
View
|
1
|
14 chunks |
+16 lines, -9 lines |
0 comments
|
Download
|
 |
M |
components/autofill/content/browser/content_autofill_driver.h
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
components/autofill/content/browser/content_autofill_driver.cc
|
View
|
|
1 chunk |
+3 lines, -2 lines |
0 comments
|
Download
|
 |
M |
components/autofill/content/browser/content_autofill_driver_unittest.cc
|
View
|
|
2 chunks |
+12 lines, -4 lines |
0 comments
|
Download
|
 |
M |
components/autofill/content/common/autofill_messages.h
|
View
|
|
2 chunks |
+6 lines, -4 lines |
0 comments
|
Download
|
 |
M |
components/autofill/content/renderer/autofill_agent.h
|
View
|
1
|
2 chunks |
+5 lines, -3 lines |
0 comments
|
Download
|
 |
M |
components/autofill/content/renderer/autofill_agent.cc
|
View
|
1
|
3 chunks |
+11 lines, -11 lines |
0 comments
|
Download
|
 |
M |
components/autofill/content/renderer/password_autofill_agent.h
|
View
|
1
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
components/autofill/content/renderer/password_autofill_agent.cc
|
View
|
1
|
3 chunks |
+8 lines, -5 lines |
0 comments
|
Download
|
 |
M |
components/autofill/core/browser/autocomplete_history_manager.h
|
View
|
1
|
1 chunk |
+3 lines, -0 lines |
0 comments
|
Download
|
 |
M |
components/autofill/core/browser/autocomplete_history_manager.cc
|
View
|
1
|
2 chunks |
+6 lines, -2 lines |
0 comments
|
Download
|
 |
M |
components/autofill/core/browser/autofill_driver.h
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
components/autofill/core/browser/autofill_external_delegate.h
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
components/autofill/core/browser/autofill_external_delegate.cc
|
View
|
|
1 chunk |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
components/autofill/core/browser/autofill_external_delegate_unittest.cc
|
View
|
|
3 chunks |
+12 lines, -9 lines |
0 comments
|
Download
|
 |
M |
components/autofill/core/browser/autofill_popup_delegate.h
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
components/autofill/core/browser/personal_data_manager.cc
|
View
|
1
|
2 chunks |
+2 lines, -0 lines |
0 comments
|
Download
|
 |
M |
components/autofill/core/browser/suggestion.h
|
View
|
|
1 chunk |
+3 lines, -0 lines |
0 comments
|
Download
|
 |
M |
components/autofill/core/browser/suggestion.cc
|
View
|
1
|
3 chunks |
+7 lines, -5 lines |
0 comments
|
Download
|
 |
M |
components/autofill/core/browser/test_autofill_driver.h
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
components/autofill/core/browser/test_autofill_driver.cc
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
components/autofill/ios/browser/autofill_driver_ios.h
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
components/password_manager/content/browser/content_password_manager_driver.h
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
components/password_manager/content/browser/content_password_manager_driver.cc
|
View
|
|
1 chunk |
+4 lines, -3 lines |
0 comments
|
Download
|
 |
M |
components/password_manager/core/browser/password_autofill_manager.h
|
View
|
|
3 chunks |
+8 lines, -3 lines |
0 comments
|
Download
|
 |
M |
components/password_manager/core/browser/password_autofill_manager.cc
|
View
|
1
|
6 chunks |
+13 lines, -8 lines |
0 comments
|
Download
|
 |
M |
components/password_manager/core/browser/password_autofill_manager_unittest.cc
|
View
|
|
2 chunks |
+11 lines, -8 lines |
0 comments
|
Download
|
 |
M |
components/password_manager/core/browser/password_manager_driver.h
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
components/password_manager/core/browser/stub_password_manager_driver.h
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
components/password_manager/core/browser/stub_password_manager_driver.cc
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
Total messages: 4 (1 generated)
|