[Autofill/Autocomplete Feature] Substring matching instead of prefix matching.

components/password_manager/core/browser/password_autofill_manager.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/password_manager/core/browser/password_autofill_manager.h"
 
 #include <vector>
 
 #include "base/logging.h"
 #include "base/metrics/histogram_macros.h"
@@ skipping 54 matching lines @@
 void GetSuggestions(const autofill::PasswordFormFillData& fill_data,
                     const base::string16& current_username,
                     std::vector<autofill::Suggestion>* suggestions,
                     bool show_all) {
   if (show_all || base::StartsWith(fill_data.username_field.value,
                                    current_username, false)) {
     autofill::Suggestion suggestion(
         ReplaceEmptyUsername(fill_data.username_field.value));
     suggestion.label = GetHumanReadableRealm(fill_data.preferred_realm);
     suggestion.frontend_id = autofill::POPUP_ITEM_ID_PASSWORD_ENTRY;
+    suggestion.match_start = current_username.size();
     suggestions->push_back(suggestion);
   }
 
   for (const auto& login : fill_data.additional_logins) {
     if (show_all || base::StartsWith(login.first, current_username, false)) {
       autofill::Suggestion suggestion(ReplaceEmptyUsername(login.first));
       suggestion.label = GetHumanReadableRealm(login.second.realm);
       suggestion.frontend_id = autofill::POPUP_ITEM_ID_PASSWORD_ENTRY;
+      suggestion.match_start = current_username.size();
       suggestions->push_back(suggestion);
     }
   }
 
   for (const auto& usernames : fill_data.other_possible_usernames) {
     for (size_t i = 0; i < usernames.second.size(); ++i) {
       if (show_all ||
           base::StartsWith(usernames.second[i], current_username, false)) {
         autofill::Suggestion suggestion(
             ReplaceEmptyUsername(usernames.second[i]));
         suggestion.label = GetHumanReadableRealm(usernames.first.realm);
         suggestion.frontend_id = autofill::POPUP_ITEM_ID_PASSWORD_ENTRY;
+        suggestion.match_start = current_username.size();
         suggestions->push_back(suggestion);
       }
     }
   }
 }
 
 }  // namespace
 
 ////////////////////////////////////////////////////////////////////////////////
 // PasswordAutofillManager, public:
@@ skipping 19 matching lines @@
     bool is_android_credential = FacetURI::FromPotentiallyInvalidSpec(
         password_and_realm.realm).IsValidAndroidFacetURI();
     metrics_util::LogFilledCredentialIsFromAndroidApp(is_android_credential);
     password_manager_driver_->FillSuggestion(
         username, password_and_realm.password);
     return true;
   }
   return false;
 }
 
-bool PasswordAutofillManager::PreviewSuggestion(
-    int key,
-    const base::string16& username) {
+bool PasswordAutofillManager::PreviewSuggestion(int key,
+                                                const base::string16& username,
+                                                size_t match_start) {
   autofill::PasswordFormFillData fill_data;
   autofill::PasswordAndRealm password_and_realm;
   if (FindLoginInfo(key, &fill_data) &&
       GetPasswordAndRealmForUsername(
           username, fill_data, &password_and_realm)) {
     password_manager_driver_->PreviewSuggestion(
-        username, password_and_realm.password);
+        username, password_and_realm.password, match_start);
     return true;
   }
   return false;
 }
 
 void PasswordAutofillManager::OnAddPasswordFormMapping(
     int key,
     const autofill::PasswordFormFillData& fill_data) {
   if (!autofill::IsValidPasswordFormFillData(fill_data))
     return;
@@ skipping 42 matching lines @@
 }
 
 bool PasswordAutofillManager::FillSuggestionForTest(
     int key,
     const base::string16& username) {
   return FillSuggestion(key, username);
 }
 
 bool PasswordAutofillManager::PreviewSuggestionForTest(
     int key,
-    const base::string16& username) {
-  return PreviewSuggestion(key, username);
+    const base::string16& username,
+    size_t match_start) {
+  return PreviewSuggestion(key, username, match_start);
 }
 
 void PasswordAutofillManager::OnPopupShown() {
 }
 
 void PasswordAutofillManager::OnPopupHidden() {
 }
 
 void PasswordAutofillManager::DidSelectSuggestion(const base::string16& value,
-                                                  int identifier) {
+                                                  int identifier,
+                                                  size_t match_start) {
   ClearPreviewedForm();
-  bool success = PreviewSuggestion(form_data_key_, value);
+  bool success = PreviewSuggestion(form_data_key_, value, match_start);
   DCHECK(success);
 }
 
 void PasswordAutofillManager::DidAcceptSuggestion(const base::string16& value,
                                                   int identifier,
                                                   int position) {
   bool success = FillSuggestion(form_data_key_, value);
   DCHECK(success);
   autofill_client_->HideAutofillPopup();
 }
@@ skipping 68 matching lines @@
     autofill::PasswordFormFillData* found_password) {
   LoginToPasswordInfoMap::iterator iter = login_to_password_info_.find(key);
   if (iter == login_to_password_info_.end())
     return false;
 
   *found_password = iter->second;
   return true;
 }
 
 }  //  namespace password_manager