Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Side by Side Diff: chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc

Issue 1208133002: [Autofill/Autocomplete Feature] Substring matching instead of prefix matching. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added |match_start| usage. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/autofill/autofill_dialog_controller_impl.h" 5 #include "chrome/browser/ui/autofill/autofill_dialog_controller_impl.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <map> 8 #include <map>
9 #include <string> 9 #include <string>
10 10
(...skipping 2359 matching lines...) Expand 10 before | Expand all | Expand 10 after
2370 ScopedViewUpdates update(view_.get()); 2370 ScopedViewUpdates update(view_.get());
2371 view_->UpdateErrorBubble(); 2371 view_->UpdateErrorBubble();
2372 2372
2373 AutofillMetrics::LogDialogPopupEvent(AutofillMetrics::DIALOG_POPUP_SHOWN); 2373 AutofillMetrics::LogDialogPopupEvent(AutofillMetrics::DIALOG_POPUP_SHOWN);
2374 } 2374 }
2375 2375
2376 void AutofillDialogControllerImpl::OnPopupHidden() {} 2376 void AutofillDialogControllerImpl::OnPopupHidden() {}
2377 2377
2378 void AutofillDialogControllerImpl::DidSelectSuggestion( 2378 void AutofillDialogControllerImpl::DidSelectSuggestion(
2379 const base::string16& value, 2379 const base::string16& value,
2380 int identifier) { 2380 int identifier,
2381 size_t match_start) {
2381 // TODO(estade): implement. 2382 // TODO(estade): implement.
2382 } 2383 }
2383 2384
2384 void AutofillDialogControllerImpl::DidAcceptSuggestion( 2385 void AutofillDialogControllerImpl::DidAcceptSuggestion(
2385 const base::string16& value, 2386 const base::string16& value,
2386 int identifier, 2387 int identifier,
2387 int position) { 2388 int position) {
2388 DCHECK_NE(UNKNOWN_TYPE, popup_input_type_); 2389 DCHECK_NE(UNKNOWN_TYPE, popup_input_type_);
2389 // Because |HidePopup()| can be called from |UpdateSection()|, remember the 2390 // Because |HidePopup()| can be called from |UpdateSection()|, remember the
2390 // type of the input for later here. 2391 // type of the input for later here.
(...skipping 1726 matching lines...) Expand 10 before | Expand all | Expand 10 after
4117 view_->UpdateButtonStrip(); 4118 view_->UpdateButtonStrip();
4118 } 4119 }
4119 4120
4120 void AutofillDialogControllerImpl::FetchWalletCookie() { 4121 void AutofillDialogControllerImpl::FetchWalletCookie() {
4121 net::URLRequestContextGetter* request_context = profile_->GetRequestContext(); 4122 net::URLRequestContextGetter* request_context = profile_->GetRequestContext();
4122 signin_helper_.reset(new wallet::WalletSigninHelper(this, request_context)); 4123 signin_helper_.reset(new wallet::WalletSigninHelper(this, request_context));
4123 signin_helper_->StartWalletCookieValueFetch(); 4124 signin_helper_->StartWalletCookieValueFetch();
4124 } 4125 }
4125 4126
4126 } // namespace autofill 4127 } // namespace autofill
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698