[Autofill/Autocomplete Feature] Substring matching instead of prefix matching.

components/password_manager/core/browser/password_autofill_manager_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/password_manager/core/browser/password_autofill_manager.h"
 
 #include "base/compiler_specific.h"
 #include "base/message_loop/message_loop.h"
 #include "base/strings/utf_string_conversions.h"
 #include "components/autofill/core/browser/popup_item_ids.h"
@@ skipping 30 matching lines @@
 }
 
 namespace password_manager {
 
 namespace {
 
 class MockPasswordManagerDriver : public StubPasswordManagerDriver {
  public:
   MOCK_METHOD2(FillSuggestion,
                void(const base::string16&, const base::string16&));
-  MOCK_METHOD2(PreviewSuggestion,
-               void(const base::string16&, const base::string16&));
+  MOCK_METHOD3(PreviewSuggestion,
+               void(const base::string16&,
+                    const base::string16&,
+                    size_t match_start));
 };
 
 class TestPasswordManagerClient : public StubPasswordManagerClient {
  public:
   MockPasswordManagerDriver* mock_driver() { return &driver_; }
 
  private:
   MockPasswordManagerDriver driver_;
 };
 
@@ skipping 76 matching lines @@
 
   password_autofill_manager_->DidNavigateMainFrame();
   EXPECT_FALSE(password_autofill_manager_->FillSuggestionForTest(
       fill_data_id(), test_username_));
 }
 
 TEST_F(PasswordAutofillManagerTest, PreviewSuggestion) {
   scoped_ptr<TestPasswordManagerClient> client(new TestPasswordManagerClient);
   InitializePasswordAutofillManager(client.get(), nullptr);
 
+  size_t match_start = 0;
   EXPECT_CALL(*client->mock_driver(),
-              PreviewSuggestion(test_username_, test_password_));
+              PreviewSuggestion(test_username_, test_password_, match_start));
   EXPECT_TRUE(password_autofill_manager_->PreviewSuggestionForTest(
-      fill_data_id(), test_username_));
+      fill_data_id(), test_username_, match_start));
   testing::Mock::VerifyAndClearExpectations(client->mock_driver());
 
-  EXPECT_CALL(*client->mock_driver(), PreviewSuggestion(_, _)).Times(0);
+  EXPECT_CALL(*client->mock_driver(), PreviewSuggestion(_, _, _)).Times(0);
   EXPECT_FALSE(password_autofill_manager_->PreviewSuggestionForTest(
-      fill_data_id(), base::ASCIIToUTF16(kInvalidUsername)));
+      fill_data_id(), base::ASCIIToUTF16(kInvalidUsername), match_start));
 
   const int invalid_fill_data_id = fill_data_id() + 1;
 
   EXPECT_FALSE(password_autofill_manager_->PreviewSuggestionForTest(
-      invalid_fill_data_id, test_username_));
+      invalid_fill_data_id, test_username_, match_start));
 
   password_autofill_manager_->DidNavigateMainFrame();
   EXPECT_FALSE(password_autofill_manager_->PreviewSuggestionForTest(
-      fill_data_id(), test_username_));
+      fill_data_id(), test_username_, match_start));
 }
 
 // Test that the popup is marked as visible after recieving password
 // suggestions.
 TEST_F(PasswordAutofillManagerTest, ExternalDelegatePasswordSuggestions) {
   scoped_ptr<TestPasswordManagerClient> client(new TestPasswordManagerClient);
   scoped_ptr<MockAutofillClient> autofill_client(new MockAutofillClient);
   InitializePasswordAutofillManager(client.get(), autofill_client.get());
 
   gfx::RectF element_bounds;
@@ skipping 171 matching lines @@
                   SuggestionVectorValuesAre(testing::UnorderedElementsAre(
                       title,
                       test_username_)),
                   _));
   password_autofill_manager_->OnShowPasswordSuggestions(
       dummy_key, base::i18n::RIGHT_TO_LEFT, test_username_,
       autofill::IS_PASSWORD_FIELD, element_bounds);
 }
 
 }  // namespace password_manager