components/password_manager/content/browser/content_password_manager_driver.cc - Issue 1208133002: [Autofill/Autocomplete Feature] Substring matching instead of prefix matching.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/content/browser/content_password_manager_driver.cc

Issue 1208133002: [Autofill/Autocomplete Feature] Substring matching instead of prefix matching. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added |match_start| usage. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/content/browser/content_password_manager_driver.h ('k') | components/password_manager/core/browser/password_autofill_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/content/browser/content_password_manager_driver.cc

diff --git a/components/password_manager/content/browser/content_password_manager_driver.cc b/components/password_manager/content/browser/content_password_manager_driver.cc

index ffaf3ac58cef509fbd55ecf7b772da1167bec703..8a9f5903c45d7e0e8301cc4b17d7b32b9f9b0ad2 100644

--- a/components/password_manager/content/browser/content_password_manager_driver.cc

+++ b/components/password_manager/content/browser/content_password_manager_driver.cc

@@ -95,10 +95,11 @@ void ContentPasswordManagerDriver::FillSuggestion(

void ContentPasswordManagerDriver::PreviewSuggestion(

const base::string16& username,

- const base::string16& password) {

+ const base::string16& password,

+ size_t match_start) {

content::RenderFrameHost* host = render_frame_host_;

- host->Send(new AutofillMsg_PreviewPasswordSuggestion(host->GetRoutingID(),

- username, password));

+ host->Send(new AutofillMsg_PreviewPasswordSuggestion(

+ host->GetRoutingID(), username, password, match_start));

}

void ContentPasswordManagerDriver::ClearPreviewedForm() {