components/autofill/content/renderer/password_autofill_agent.h - Issue 1208133002: [Autofill/Autocomplete Feature] Substring matching instead of prefix matching.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/renderer/password_autofill_agent.h

Issue 1208133002: [Autofill/Autocomplete Feature] Substring matching instead of prefix matching. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added |match_start| usage. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/content/renderer/autofill_agent.cc ('k') | components/autofill/content/renderer/password_autofill_agent.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/renderer/password_autofill_agent.h

diff --git a/components/autofill/content/renderer/password_autofill_agent.h b/components/autofill/content/renderer/password_autofill_agent.h

index 9f070f358b8419d2cb33f3112f50cb75261f1870..66de52030f8204d8f368593cdb9dc28ce1f94b27 100644

--- a/components/autofill/content/renderer/password_autofill_agent.h

+++ b/components/autofill/content/renderer/password_autofill_agent.h

@@ -56,7 +56,8 @@ class PasswordAutofillAgent : public content::RenderFrameObserver {

// values. Returns true if the fields were previewed, false otherwise.

bool PreviewSuggestion(const blink::WebNode& node,

const blink::WebString& username,

- const blink::WebString& password);

+ const blink::WebString& password,

+ int match_start);

// Clears the preview for the username and password fields, restoring both to

// their previous filled state. Return false if no login information was