|
Change ownership of BookmarkClient
Change BookmarkClient to no longer be a KeyedService and instead to be
owned by BookmarkModel to 1. simplify the lifetime of the object, 2.
prevent incorrect access outside of the history code and 3. prevent
breaking the componentization again.
BUG= 359565, 383583
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+227 lines, -284 lines) |
Patch |
 |
M |
chrome/browser/autocomplete/bookmark_provider_unittest.cc
|
View
|
|
2 chunks |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/bookmarks/bookmark_model_factory.cc
|
View
|
|
3 chunks |
+2 lines, -6 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/bookmarks/chrome_bookmark_client.h
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/bookmarks/chrome_bookmark_client.cc
|
View
|
|
1 chunk |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
D |
chrome/browser/bookmarks/chrome_bookmark_client_factory.h
|
View
|
|
1 chunk |
+0 lines, -41 lines |
0 comments
|
Download
|
 |
D |
chrome/browser/bookmarks/chrome_bookmark_client_factory.cc
|
View
|
|
1 chunk |
+0 lines, -46 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/history/DEPS
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc
|
View
|
|
3 chunks |
+2 lines, -14 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/sync/profile_sync_service_bookmark_unittest.cc
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/bookmarks/bookmark_editor_unittest.cc
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/bookmarks/bookmark_ui_utils_unittest.cc
|
View
|
|
2 chunks |
+2 lines, -4 lines |
0 comments
|
Download
|
 |
M |
chrome/chrome_browser.gypi
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/test/base/testing_profile.cc
|
View
|
|
4 chunks |
+3 lines, -14 lines |
0 comments
|
Download
|
 |
M |
components/bookmarks/browser/bookmark_client.h
|
View
|
|
5 chunks |
+15 lines, -8 lines |
0 comments
|
Download
|
 |
M |
components/bookmarks/browser/bookmark_client.cc
|
View
|
|
1 chunk |
+2 lines, -14 lines |
0 comments
|
Download
|
 |
M |
components/bookmarks/browser/bookmark_codec_unittest.cc
|
View
|
|
7 chunks |
+8 lines, -10 lines |
0 comments
|
Download
|
 |
M |
components/bookmarks/browser/bookmark_expanded_state_tracker_unittest.cc
|
View
|
|
1 chunk |
+6 lines, -4 lines |
0 comments
|
Download
|
 |
M |
components/bookmarks/browser/bookmark_index.cc
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
components/bookmarks/browser/bookmark_index_unittest.cc
|
View
|
|
11 chunks |
+43 lines, -12 lines |
0 comments
|
Download
|
 |
M |
components/bookmarks/browser/bookmark_model.h
|
View
|
|
7 chunks |
+9 lines, -6 lines |
0 comments
|
Download
|
 |
M |
components/bookmarks/browser/bookmark_model.cc
|
View
|
|
7 chunks |
+11 lines, -8 lines |
0 comments
|
Download
|
 |
M |
components/bookmarks/browser/bookmark_model_unittest.cc
|
View
|
|
4 chunks |
+4 lines, -6 lines |
0 comments
|
Download
|
 |
M |
components/bookmarks/browser/bookmark_node_data_unittest.cc
|
View
|
|
2 chunks |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
components/bookmarks/browser/bookmark_utils_unittest.cc
|
View
|
|
15 chunks |
+17 lines, -33 lines |
0 comments
|
Download
|
 |
M |
components/bookmarks/managed/managed_bookmarks_tracker_unittest.cc
|
View
|
|
3 chunks |
+4 lines, -5 lines |
0 comments
|
Download
|
 |
M |
components/bookmarks/test/test_bookmark_client.h
|
View
|
|
2 chunks |
+26 lines, -9 lines |
0 comments
|
Download
|
 |
M |
components/bookmarks/test/test_bookmark_client.cc
|
View
|
|
2 chunks |
+60 lines, -15 lines |
0 comments
|
Download
|
 |
M |
components/enhanced_bookmarks/bookmark_image_service.cc
|
View
|
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
 |
M |
components/enhanced_bookmarks/enhanced_bookmark_model_unittest.cc
|
View
|
|
3 chunks |
+1 line, -4 lines |
0 comments
|
Download
|
 |
M |
components/undo/bookmark_undo_service_test.cc
|
View
|
|
3 chunks |
+1 line, -6 lines |
0 comments
|
Download
|
Depends on Patchset:
Total messages: 3 (1 generated)
|