Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Side by Side Diff: components/bookmarks/managed/managed_bookmarks_tracker_unittest.cc

Issue 1198963014: Change ownership of BookmarkClient (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cleanup_managed_and_supervised_nodes
Patch Set: Rebase Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/bookmarks/managed/managed_bookmarks_tracker.h" 5 #include "components/bookmarks/managed/managed_bookmarks_tracker.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/files/file_path.h" 8 #include "base/files/file_path.h"
9 #include "base/memory/scoped_ptr.h" 9 #include "base/memory/scoped_ptr.h"
10 #include "base/message_loop/message_loop.h" 10 #include "base/message_loop/message_loop.h"
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 BookmarkPermanentNode* managed_node = new BookmarkPermanentNode(100); 52 BookmarkPermanentNode* managed_node = new BookmarkPermanentNode(100);
53 ManagedBookmarksTracker::LoadInitial( 53 ManagedBookmarksTracker::LoadInitial(
54 managed_node, 54 managed_node,
55 prefs_.GetList(ManagedBookmarksTracker::GetPrefName(is_supervised)), 55 prefs_.GetList(ManagedBookmarksTracker::GetPrefName(is_supervised)),
56 101); 56 101);
57 managed_node->set_visible(!managed_node->empty()); 57 managed_node->set_visible(!managed_node->empty());
58 managed_node->SetTitle(l10n_util::GetStringUTF16( 58 managed_node->SetTitle(l10n_util::GetStringUTF16(
59 is_supervised ? IDS_BOOKMARK_BAR_SUPERVISED_FOLDER_DEFAULT_NAME 59 is_supervised ? IDS_BOOKMARK_BAR_SUPERVISED_FOLDER_DEFAULT_NAME
60 : IDS_BOOKMARK_BAR_MANAGED_FOLDER_DEFAULT_NAME)); 60 : IDS_BOOKMARK_BAR_MANAGED_FOLDER_DEFAULT_NAME));
61 61
62 bookmarks::TestBookmarkClient* client = nullptr;
62 bookmarks::BookmarkPermanentNodeList extra_nodes; 63 bookmarks::BookmarkPermanentNodeList extra_nodes;
63 extra_nodes.push_back(managed_node); 64 extra_nodes.push_back(managed_node);
64 client_.SetExtraNodesToLoad(extra_nodes.Pass());
65 65
66 model_.reset(new BookmarkModel(&client_)); 66 model_ = TestBookmarkClient::CreateModel(extra_nodes.Pass(), &client, true);
67 model_->AddObserver(&observer_); 67 model_->AddObserver(&observer_);
68 EXPECT_CALL(observer_, BookmarkModelLoaded(model_.get(), _)); 68 EXPECT_CALL(observer_, BookmarkModelLoaded(model_.get(), _));
69 model_->Load(&prefs_, std::string(), base::FilePath(), 69 model_->Load(&prefs_, std::string(), base::FilePath(),
70 base::ThreadTaskRunnerHandle::Get(), 70 base::ThreadTaskRunnerHandle::Get(),
71 base::ThreadTaskRunnerHandle::Get()); 71 base::ThreadTaskRunnerHandle::Get());
72 bookmarks::test::WaitForBookmarkModelToLoad(model_.get()); 72 bookmarks::test::WaitForBookmarkModelToLoad(model_.get());
73 Mock::VerifyAndClearExpectations(&observer_); 73 Mock::VerifyAndClearExpectations(&observer_);
74 74
75 ASSERT_EQ(1u, client_.extra_nodes().size()); 75 ASSERT_EQ(1u, client->extra_nodes().size());
76 managed_node_ = client_.extra_nodes()[0]; 76 managed_node_ = client->extra_nodes()[0];
77 ASSERT_EQ(managed_node, managed_node_); 77 ASSERT_EQ(managed_node, managed_node_);
78 78
79 managed_bookmarks_tracker_.reset(new ManagedBookmarksTracker( 79 managed_bookmarks_tracker_.reset(new ManagedBookmarksTracker(
80 model_.get(), 80 model_.get(),
81 &prefs_, 81 &prefs_,
82 is_supervised, 82 is_supervised,
83 base::Bind(&ManagedBookmarksTrackerTest::GetManagementDomain))); 83 base::Bind(&ManagedBookmarksTrackerTest::GetManagementDomain)));
84 managed_bookmarks_tracker_->Init(managed_node_); 84 managed_bookmarks_tracker_->Init(managed_node_);
85 } 85 }
86 86
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
159 if (!dict->GetString("url", &url) || node->url() != GURL(url)) 159 if (!dict->GetString("url", &url) || node->url() != GURL(url))
160 return false; 160 return false;
161 } else { 161 } else {
162 return false; 162 return false;
163 } 163 }
164 return true; 164 return true;
165 } 165 }
166 166
167 base::MessageLoop loop_; 167 base::MessageLoop loop_;
168 TestingPrefServiceSimple prefs_; 168 TestingPrefServiceSimple prefs_;
169 bookmarks::TestBookmarkClient client_;
170 scoped_ptr<BookmarkModel> model_; 169 scoped_ptr<BookmarkModel> model_;
171 bookmarks::MockBookmarkModelObserver observer_; 170 bookmarks::MockBookmarkModelObserver observer_;
172 BookmarkPermanentNode* managed_node_; 171 BookmarkPermanentNode* managed_node_;
173 scoped_ptr<ManagedBookmarksTracker> managed_bookmarks_tracker_; 172 scoped_ptr<ManagedBookmarksTracker> managed_bookmarks_tracker_;
174 }; 173 };
175 174
176 TEST_F(ManagedBookmarksTrackerTest, Empty) { 175 TEST_F(ManagedBookmarksTrackerTest, Empty) {
177 CreateModel(false /* is_supervised */); 176 CreateModel(false /* is_supervised */);
178 EXPECT_TRUE(model_->bookmark_bar_node()->empty()); 177 EXPECT_TRUE(model_->bookmark_bar_node()->empty());
179 EXPECT_TRUE(model_->other_node()->empty()); 178 EXPECT_TRUE(model_->other_node()->empty());
(...skipping 154 matching lines...) Expand 10 before | Expand all | Expand 10 after
334 Mock::VerifyAndClearExpectations(&observer_); 333 Mock::VerifyAndClearExpectations(&observer_);
335 334
336 EXPECT_CALL(observer_, BookmarkAllUserNodesRemoved(model_.get(), _)); 335 EXPECT_CALL(observer_, BookmarkAllUserNodesRemoved(model_.get(), _));
337 model_->RemoveAllUserBookmarks(); 336 model_->RemoveAllUserBookmarks();
338 EXPECT_EQ(2, managed_node()->child_count()); 337 EXPECT_EQ(2, managed_node()->child_count());
339 EXPECT_EQ(0, model_->bookmark_bar_node()->child_count()); 338 EXPECT_EQ(0, model_->bookmark_bar_node()->child_count());
340 Mock::VerifyAndClearExpectations(&observer_); 339 Mock::VerifyAndClearExpectations(&observer_);
341 } 340 }
342 341
343 } // namespace bookmarks 342 } // namespace bookmarks
OLDNEW
« no previous file with comments | « components/bookmarks/browser/bookmark_utils_unittest.cc ('k') | components/bookmarks/test/test_bookmark_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698