components/bookmarks/browser/bookmark_node_data_unittest.cc - Issue 1198963014: Change ownership of BookmarkClient

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/bookmarks/browser/bookmark_node_data_unittest.cc

Issue 1198963014: Change ownership of BookmarkClient (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cleanup_managed_and_supervised_nodes

Patch Set: Rebase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/bookmarks/browser/bookmark_model_unittest.cc ('k') | components/bookmarks/browser/bookmark_utils_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/bookmarks/browser/bookmark_node_data_unittest.cc

diff --git a/components/bookmarks/browser/bookmark_node_data_unittest.cc b/components/bookmarks/browser/bookmark_node_data_unittest.cc

index 3e11e3e99d6db4d98e4b0b25ddee4c7840e2ac56..660b966b6a693237f2923723feebff1093fc2d18 100644

--- a/components/bookmarks/browser/bookmark_node_data_unittest.cc

+++ b/components/bookmarks/browser/bookmark_node_data_unittest.cc

@@ -28,7 +28,7 @@ class BookmarkNodeDataTest : public testing::Test {

void SetUp() override {

event_source_ = ui::PlatformEventSource::CreateDefault();

- model_ = client_.CreateModel();

+ model_ = TestBookmarkClient::CreateModel();

test::WaitForBookmarkModelToLoad(model_.get());

bool success = profile_dir_.CreateUniqueTempDir();

ASSERT_TRUE(success);

@@ -51,7 +51,6 @@ class BookmarkNodeDataTest : public testing::Test {

private:

base::ScopedTempDir profile_dir_;

- TestBookmarkClient client_;

scoped_ptr<BookmarkModel> model_;

scoped_ptr<ui::PlatformEventSource> event_source_;

base::MessageLoopForUI loop_;

« no previous file with comments | « components/bookmarks/browser/bookmark_model_unittest.cc ('k') | components/bookmarks/browser/bookmark_utils_unittest.cc » ('j') | no next file with comments »