DescriptionRemove dependency of HistoryServiceFactory on ChromeBookmarkClientFactory
Add a method Init() to HistoryClient called by HistoryService so that
the client can connect HistoryService and BookmarkModel events.
HistoryClient implements BaseBookmarkModelObserver interface and forward
the URLs removed from bookmarks event to HistoryService. Symmetrically it
register a callback that will send to BookmarkModel the events about
changes to favicons.
Remove the hackish access to ChromeBookmarkClientFactory from the
HistoryServiceFactory.
BUG=359565
Committed: https://crrev.com/64823f69cd200d77e7ffc8ac949f6df7168f9183
Cr-Commit-Position: refs/heads/master@{#336346}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Remove change to BookmarkModelObserver and use BaseBookmarkModelObserver #
Total comments: 6
Patch Set 3 : Remove superfluous #include & rename Init to OnHistoryServiceCreated #Patch Set 4 : Fix unit_tests on android (only register as BookmarkModelObserver if HistoryService is initialized) #Messages
Total messages: 15 (5 generated)
|