Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1198373002: Split HistoryClient in two objects (Closed)

Created:
5 years, 6 months ago by sdefresne
Modified:
5 years, 6 months ago
Reviewers:
Nicolas Zea, sky
CC:
browser-components-watch_chromium.org, chromium-reviews, maniscalco+watch_chromium.org, maxbogue+watch_chromium.org, plaree+watch_chromium.org, pvalenzuela+watch_chromium.org, tim+watch_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@1192403002
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Split HistoryClient in two objects HistoryClient exposed methods accessed by UI or History thread. Split the object in two only exposing method accessed by a single thread. The HistoryClient methods can only be invoked from UI thread while the HistoryBackendClient methods can only be invoked from History thread. This separation is required before the History code can be refactored not to create it's own thread. BUG=459548, 477975 Committed: https://crrev.com/542b71e372426c2547be0a689c2d7053b1ffdeff Cr-Commit-Position: refs/heads/master@{#335779}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add comments in ChromeHistoryBackendClient #

Unified diffs Side-by-side diffs Delta from patch set Stats (+492 lines, -350 lines) Patch
M chrome/browser/history/android/android_provider_backend.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/history/android/android_provider_backend.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/history/android/android_provider_backend_unittest.cc View 30 chunks +36 lines, -33 lines 0 comments Download
A chrome/browser/history/chrome_history_backend_client.h View 1 chunk +44 lines, -0 lines 0 comments Download
A chrome/browser/history/chrome_history_backend_client.cc View 1 1 chunk +93 lines, -0 lines 0 comments Download
M chrome/browser/history/chrome_history_client.h View 2 chunks +4 lines, -18 lines 0 comments Download
M chrome/browser/history/chrome_history_client.cc View 4 chunks +4 lines, -77 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_typed_url_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M components/history.gypi View 1 chunk +1 line, -1 line 0 comments Download
M components/history/core/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/history/core/browser/expire_history_backend.h View 4 chunks +8 lines, -15 lines 0 comments Download
M components/history/core/browser/expire_history_backend.cc View 7 chunks +8 lines, -19 lines 0 comments Download
M components/history/core/browser/expire_history_backend_unittest.cc View 3 chunks +4 lines, -1 line 0 comments Download
M components/history/core/browser/history_backend.h View 4 chunks +4 lines, -10 lines 0 comments Download
M components/history/core/browser/history_backend.cc View 9 chunks +16 lines, -20 lines 0 comments Download
A components/history/core/browser/history_backend_client.h View 1 chunk +65 lines, -0 lines 0 comments Download
A + components/history/core/browser/history_backend_client.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M components/history/core/browser/history_backend_unittest.cc View 7 chunks +7 lines, -17 lines 0 comments Download
M components/history/core/browser/history_client.h View 2 chunks +11 lines, -47 lines 0 comments Download
D components/history/core/browser/history_client.cc View 1 chunk +0 lines, -51 lines 0 comments Download
M components/history/core/browser/history_service.cc View 2 chunks +3 lines, -1 line 0 comments Download
M components/history/core/browser/thumbnail_database.h View 3 chunks +3 lines, -3 lines 0 comments Download
M components/history/core/browser/thumbnail_database.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M components/history/core/browser/typed_url_syncable_service_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/history/core/test/history_backend_db_base_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/history/core/test/history_client_fake_bookmarks.h View 2 chunks +14 lines, -6 lines 0 comments Download
M components/history/core/test/history_client_fake_bookmarks.cc View 1 chunk +144 lines, -13 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (8 generated)
sdefresne
sky: please review zea: OWNERS review of //chrome/browser/sync
5 years, 6 months ago (2015-06-22 21:47:23 UTC) #7
sky
LGTM https://codereview.chromium.org/1198373002/diff/80001/components/history/core/browser/expire_history_backend.cc File components/history/core/browser/expire_history_backend.cc (left): https://codereview.chromium.org/1198373002/diff/80001/components/history/core/browser/expire_history_backend.cc#oldcode513 components/history/core/browser/expire_history_backend.cc:513: // We use the history client to determine ...
5 years, 6 months ago (2015-06-23 15:22:30 UTC) #8
Nicolas Zea
sync lgtm
5 years, 6 months ago (2015-06-23 17:45:29 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1198373002/100001
5 years, 6 months ago (2015-06-23 22:18:24 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:100001)
5 years, 6 months ago (2015-06-23 22:28:42 UTC) #13
commit-bot: I haz the power
5 years, 6 months ago (2015-06-23 22:30:25 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/542b71e372426c2547be0a689c2d7053b1ffdeff
Cr-Commit-Position: refs/heads/master@{#335779}

Powered by Google App Engine
This is Rietveld 408576698