chrome/browser/ui/bookmarks/bookmark_ui_utils_unittest.cc - Issue 1198963014: Change ownership of BookmarkClient

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/bookmarks/bookmark_ui_utils_unittest.cc

Issue 1198963014: Change ownership of BookmarkClient (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cleanup_managed_and_supervised_nodes

Patch Set: Rebase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/bookmarks/bookmark_ui_utils_unittest.cc

diff --git a/chrome/browser/ui/bookmarks/bookmark_ui_utils_unittest.cc b/chrome/browser/ui/bookmarks/bookmark_ui_utils_unittest.cc

index b0a51f9e791ec4bfa5f74023f926e3d22a3f24ec..1d10447770a8433625a4ad18b97d8fc5f7efb556 100644

--- a/chrome/browser/ui/bookmarks/bookmark_ui_utils_unittest.cc

+++ b/chrome/browser/ui/bookmarks/bookmark_ui_utils_unittest.cc

@@ -24,8 +24,7 @@ class BookmarkUIUtilsTest : public testing::Test {

};

TEST_F(BookmarkUIUtilsTest, HasBookmarkURLs) {

- bookmarks::TestBookmarkClient client;

- scoped_ptr<BookmarkModel> model(client.CreateModel());

+ scoped_ptr<BookmarkModel> model(bookmarks::TestBookmarkClient::CreateModel());

std::vector<const BookmarkNode*> nodes;

@@ -66,8 +65,7 @@ TEST_F(BookmarkUIUtilsTest, HasBookmarkURLs) {

}

TEST_F(BookmarkUIUtilsTest, HasBookmarkURLsAllowedInIncognitoMode) {

- bookmarks::TestBookmarkClient client;

- scoped_ptr<BookmarkModel> model(client.CreateModel());

+ scoped_ptr<BookmarkModel> model(bookmarks::TestBookmarkClient::CreateModel());

TestingProfile profile;

std::vector<const BookmarkNode*> nodes;

« no previous file with comments | « chrome/browser/ui/bookmarks/bookmark_editor_unittest.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »