Chromium Code Reviews Chromium Code Reviews
Issue
1186113007:
Refactor separable varying location info to be stored in GrGLProgram subclass (Closed)
DescriptionRefactor separable varying location info to be stored in GrGLProgram subclass
Refactor separable varying location info to be stored in GrGLProgram
subclass GrGLProgram instead of storing it in GrGLPathProcessor.
Separable varyings are exactly analoguous to uniforms: they are inputs
to the shader program. Shader compile-time information about uniforms is gathered to
GrGLProgramBuilder. This information is the converted to link-time
information, uniform locations, when constructing the program. Separable
varyings need to have same lifetime model.
This is needed in the future to support path rendering in Chromium. The
Chromium pseudo-extension will expose program fragment input binding
function similar to uniform binding function. Thus the separable varying
locations need to be decided and bound before link, e.g. before
GrGLProgram is created. This will be achieved in further patches by
overloading GrGLProgramBuilder::bindProgramResourceLocations() in
GrGLNvprProgramBuilder.
BUG=chromium:344330
Committed: https://skia.googlesource.com/skia/+/7aedda57f84f942b5f0ba6c1b6e7ba329e6b18f1
Patch Set 1 #Patch Set 2 : rename NvprProgram to PathProgram #Patch Set 3 : #
Total comments: 6
Patch Set 4 : address review comments #
Messages
Total messages: 10 (2 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
