Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 1178503004: Replace SetObjectProperty / DefineObjectProperty with less powerful alternatives where relevant. (Closed)

Created:
5 years, 6 months ago by Toon Verwaest
Modified:
5 years, 6 months ago
Reviewers:
Igor Sheludko, Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Replace SetObjectProperty / DefineObjectProperty with less powerful alternatives where relevant. @yangguo: please look at the debugger part of the CL. @ishell: please look at the rest. Additionally: - Ensure the LookupIterator for named properties does not accidentally get indexes in. - Fix the return value for typed array assignments to be the incoming value. BUG=v8:4137 LOG=n Committed: https://crrev.com/15aa811f8fe2708a757c3b53ca89db736aa8b222 Cr-Commit-Position: refs/heads/master@{#28954}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -296 lines) Patch
M src/api.cc View 1 5 chunks +36 lines, -12 lines 0 comments Download
M src/api-natives.cc View 1 1 chunk +11 lines, -19 lines 0 comments Download
M src/bootstrapper.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M src/ic/ic.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/json-parser.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/lookup.h View 1 3 chunks +1 line, -7 lines 0 comments Download
M src/lookup.cc View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M src/objects.h View 1 2 3 chunks +7 lines, -4 lines 0 comments Download
M src/objects.cc View 1 2 5 chunks +6 lines, -16 lines 0 comments Download
M src/objects-inl.h View 1 1 chunk +14 lines, -0 lines 0 comments Download
M src/runtime/runtime.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M src/runtime/runtime-classes.cc View 1 1 chunk +2 lines, -10 lines 0 comments Download
M src/runtime/runtime-debug.cc View 1 17 chunks +61 lines, -97 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 4 chunks +26 lines, -108 lines 0 comments Download
M src/scopeinfo.cc View 1 2 chunks +7 lines, -9 lines 0 comments Download
M test/cctest/test-debug.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Toon Verwaest
ptal
5 years, 6 months ago (2015-06-11 09:16:36 UTC) #2
Yang
On 2015/06/11 09:16:36, Toon Verwaest wrote: > ptal debugger part lgtm.
5 years, 6 months ago (2015-06-11 10:39:33 UTC) #3
Igor Sheludko
lgtm
5 years, 6 months ago (2015-06-11 15:45:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1178503004/40001
5 years, 6 months ago (2015-06-11 16:09:36 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-11 16:37:41 UTC) #8
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/15aa811f8fe2708a757c3b53ca89db736aa8b222 Cr-Commit-Position: refs/heads/master@{#28954}
5 years, 6 months ago (2015-06-11 16:38:01 UTC) #9
Igor Sheludko
5 years, 6 months ago (2015-06-11 17:20:48 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1181733002/ by ishell@chromium.org.

The reason for reverting is: Blocks revert of
https://codereview.chromium.org/1175973002.

Powered by Google App Engine
This is Rietveld 408576698