src/ic/ic.cc - Issue 1178503004: Replace SetObjectProperty / DefineObjectProperty with less powerful alternatives where relevant.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ic/ic.cc

Issue 1178503004: Replace SetObjectProperty / DefineObjectProperty with less powerful alternatives where relevant. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: rebase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ic/ic.cc

diff --git a/src/ic/ic.cc b/src/ic/ic.cc

index c0d8e005abedeb32ce95b1d70c396e590e24a719..d04fc583c44a909cc0d57c900a7da160c88236aa 100644

--- a/src/ic/ic.cc

+++ b/src/ic/ic.cc

@@ -1226,7 +1226,7 @@ static Handle<Object> TryConvertKey(Handle<Object> key, Isolate* isolate) {

} else {

int int_value = FastD2I(value);

if (value == int_value && Smi::IsValid(int_value)) {

- key = Handle<Smi>(Smi::FromInt(int_value), isolate);

+ key = handle(Smi::FromInt(int_value), isolate);

}

} else if (key->IsUndefined()) {

« no previous file with comments | « src/bootstrapper.cc ('k') | src/json-parser.h » ('j') | no next file with comments »