Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Unified Diff: src/objects-inl.h

Issue 1178503004: Replace SetObjectProperty / DefineObjectProperty with less powerful alternatives where relevant. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: rebase Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/objects.cc ('k') | src/runtime/runtime.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects-inl.h
diff --git a/src/objects-inl.h b/src/objects-inl.h
index 27528d644253793d8418fc019ec183557cd52c31..501eef4c20086a1d2361542b0117d0eb1a868340 100644
--- a/src/objects-inl.h
+++ b/src/objects-inl.h
@@ -1197,6 +1197,20 @@ MaybeHandle<Object> Object::GetProperty(Isolate* isolate,
}
+MaybeHandle<Object> JSObject::DefinePropertyOrElement(
+ Handle<JSObject> object, Handle<Name> name, Handle<Object> value,
+ PropertyAttributes attributes) {
+ uint32_t index;
+ if (name->AsArrayIndex(&index)) {
+ return SetOwnElementIgnoreAttributes(object, index, value, attributes);
+ }
+
+ // TODO(verwaest): Is this necessary?
+ if (name->IsString()) name = String::Flatten(Handle<String>::cast(name));
+ return SetOwnPropertyIgnoreAttributes(object, name, value, attributes);
+}
+
+
#define FIELD_ADDR(p, offset) \
(reinterpret_cast<byte*>(p) + offset - kHeapObjectTag)
« no previous file with comments | « src/objects.cc ('k') | src/runtime/runtime.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698