Remove GetAttributes from the mix to avoid another virtual dispatch.

Remove GetAttributes from the mix to avoid another virtual dispatch.

BUG=chromium:495949, v8:4137
LOG=n

Committed: https://crrev.com/2269b8b5a696bf4eef13590093151bff624d4175
Cr-Commit-Position: refs/heads/master@{#28953}

[Toon Verwaest, 2015-06-10 12:28:27]

verwaest@chromium.org changed reviewers:
+ ishell@chromium.org

[Toon Verwaest, 2015-06-10 12:28:28]

ptal

[Toon Verwaest, 2015-06-11 14:07:48]

Patchset #2 (id:20001) has been deleted

[Igor Sheludko, 2015-06-11 14:59:45]

lgtm with a nit:

https://codereview.chromium.org/1175973002/diff/1/src/elements.cc
File src/elements.cc (right):

https://codereview.chromium.org/1175973002/diff/1/src/elements.cc#newcode588
src/elements.cc:588: return
ElementsAccessorSubclass::GetIndexForKeyImpl(*holder, *backing_store,
Do we need HasElementImpl() given that now GetIndexForKeyImpl() does all the
dirty job?

[Toon Verwaest, 2015-06-11 15:16:06]

Addressed comment

https://codereview.chromium.org/1175973002/diff/1/src/elements.cc
File src/elements.cc (right):

https://codereview.chromium.org/1175973002/diff/1/src/elements.cc#newcode588
src/elements.cc:588: return
ElementsAccessorSubclass::GetIndexForKeyImpl(*holder, *backing_store,
On 2015/06/11 14:59:45, Igor Sheludko wrote:
> Do we need HasElementImpl() given that now GetIndexForKeyImpl() does all the
> dirty job?

Done.

[Toon Verwaest, 2015-06-11 15:16:59]

The CQ bit was checked by verwaest@chromium.org

[Toon Verwaest, 2015-06-11 15:17:01]

The patchset sent to the CQ was uploaded after l-g-t-m from ishell@chromium.org
Link to the patchset: https://codereview.chromium.org/1175973002/#ps40001
(title: "Rebased and addressed comment")

[commit-bot: I haz the power, 2015-06-11 15:17:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1175973002/40001

[commit-bot: I haz the power, 2015-06-11 16:07:26]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2015-06-11 16:07:39]

Patchset 2 (id:??) landed as
https://crrev.com/2269b8b5a696bf4eef13590093151bff624d4175
Cr-Commit-Position: refs/heads/master@{#28953}

[Igor Sheludko, 2015-06-11 17:25:00]

A revert of this CL (patchset #2 id:40001) has been created in
https://codereview.chromium.org/1179933002/ by ishell@chromium.org.

The reason for reverting is: It broke webkit_unit_tests.