Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(803)

Side by Side Diff: src/runtime/runtime.h

Issue 1178503004: Replace SetObjectProperty / DefineObjectProperty with less powerful alternatives where relevant. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: rebase Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/objects-inl.h ('k') | src/runtime/runtime-classes.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_RUNTIME_RUNTIME_H_ 5 #ifndef V8_RUNTIME_RUNTIME_H_
6 #define V8_RUNTIME_RUNTIME_H_ 6 #define V8_RUNTIME_RUNTIME_H_
7 7
8 #include "src/allocation.h" 8 #include "src/allocation.h"
9 #include "src/objects.h" 9 #include "src/objects.h"
10 #include "src/zone.h" 10 #include "src/zone.h"
(...skipping 804 matching lines...) Expand 10 before | Expand all | Expand 10 after
815 815
816 // Support getting the characters in a string using [] notation as 816 // Support getting the characters in a string using [] notation as
817 // in Firefox/SpiderMonkey, Safari and Opera. 817 // in Firefox/SpiderMonkey, Safari and Opera.
818 MUST_USE_RESULT static MaybeHandle<Object> GetElementOrCharAt( 818 MUST_USE_RESULT static MaybeHandle<Object> GetElementOrCharAt(
819 Isolate* isolate, Handle<Object> object, uint32_t index); 819 Isolate* isolate, Handle<Object> object, uint32_t index);
820 820
821 MUST_USE_RESULT static MaybeHandle<Object> SetObjectProperty( 821 MUST_USE_RESULT static MaybeHandle<Object> SetObjectProperty(
822 Isolate* isolate, Handle<Object> object, Handle<Object> key, 822 Isolate* isolate, Handle<Object> object, Handle<Object> key,
823 Handle<Object> value, LanguageMode language_mode); 823 Handle<Object> value, LanguageMode language_mode);
824 824
825 MUST_USE_RESULT static MaybeHandle<Object> DefineObjectProperty(
826 Handle<JSObject> object, Handle<Object> key, Handle<Object> value,
827 PropertyAttributes attr);
828
829 MUST_USE_RESULT static MaybeHandle<Object> GetObjectProperty( 825 MUST_USE_RESULT static MaybeHandle<Object> GetObjectProperty(
830 Isolate* isolate, Handle<Object> object, Handle<Object> key); 826 Isolate* isolate, Handle<Object> object, Handle<Object> key);
831 827
832 MUST_USE_RESULT static MaybeHandle<Object> GetPrototype( 828 MUST_USE_RESULT static MaybeHandle<Object> GetPrototype(
833 Isolate* isolate, Handle<Object> object); 829 Isolate* isolate, Handle<Object> object);
834 830
835 MUST_USE_RESULT static MaybeHandle<Name> ToName(Isolate* isolate, 831 MUST_USE_RESULT static MaybeHandle<Name> ToName(Isolate* isolate,
836 Handle<Object> key); 832 Handle<Object> key);
837 833
838 static void SetupArrayBuffer(Isolate* isolate, 834 static void SetupArrayBuffer(Isolate* isolate,
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after
929 inline bool Runtime::AtomicIsLockFree(uint32_t size) { 925 inline bool Runtime::AtomicIsLockFree(uint32_t size) {
930 return size == 1 || size == 2 || size == 4; 926 return size == 1 || size == 2 || size == 4;
931 } 927 }
932 928
933 #endif 929 #endif
934 930
935 } // namespace internal 931 } // namespace internal
936 } // namespace v8 932 } // namespace v8
937 933
938 #endif // V8_RUNTIME_RUNTIME_H_ 934 #endif // V8_RUNTIME_RUNTIME_H_
OLDNEW
« no previous file with comments | « src/objects-inl.h ('k') | src/runtime/runtime-classes.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698