Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 11753031: Revert 175152 (Closed)

Created:
7 years, 11 months ago by ncarter (slow)
Modified:
7 years, 11 months ago
Reviewers:
ncarter (slow)
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 175152 > [ui/surface] Separate image processing logic from presentation logic. > > The D3D image processing code from AcceleratedPresenter moves to its own class, "ui/surface/accelerated_surface_transformer_win.h". This split allows the image processing code to be tested independently of the present-scheduling system, and so we add unit tests doing exactly that. Utility functions (loading d3d, creating temp surfaces) doing things commonly required by test, transform, and present code -- these functions are moved to a third location, "ui/surface/d3d9_utils_win.h" > > The new unit tests -- which live in the ui_unittests binary -- make extensive use of pseudorandom image content, which I think is kind of neat. The tests use D3D HAL devices; I tried to use REF, but it didn't work, as StretchRect+LINEAR is not supported by refrast. So as a result we may have a GPU vendor dependency in these results. > > BUG=161537 > TEST=new ui_unittests > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=174028 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=174338 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=174943 > > Review URL: https://codereview.chromium.org/11464017 TBR=nick@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175161

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+237 lines, -1136 lines) Patch
D ui/surface/accelerated_surface_transformer_win.h View 1 chunk +0 lines, -81 lines 0 comments Download
D ui/surface/accelerated_surface_transformer_win.cc View 1 chunk +0 lines, -261 lines 0 comments Download
D ui/surface/accelerated_surface_transformer_win.hlsl View 1 chunk +0 lines, -28 lines 0 comments Download
D ui/surface/accelerated_surface_transformer_win_unittest.cc View 1 chunk +0 lines, -525 lines 0 comments Download
M ui/surface/accelerated_surface_win.cc View 13 chunks +237 lines, -43 lines 0 comments Download
A + ui/surface/accelerated_surface_win.hlsl View 0 chunks +-1 lines, --1 lines 0 comments Download
D ui/surface/d3d9_utils_win.h View 1 chunk +0 lines, -71 lines 0 comments Download
D ui/surface/d3d9_utils_win.cc View 1 chunk +0 lines, -119 lines 0 comments Download
M ui/surface/surface.gyp View 1 chunk +1 line, -5 lines 0 comments Download
M ui/ui_unittests.gypi View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
ncarter (slow)
7 years, 11 months ago (2013-01-04 18:53:36 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698