Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(12)

Issue 1174343003: blink:bindings: Passes the global context instead of |this| in JS. (Closed)

Created:
4 years, 5 months ago by Yuki
Modified:
4 years, 5 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, tzik, nhiroki, rginda+watch_chromium.org, chromium-apps-reviews_chromium.org, kinuko+fileapi
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

blink:bindings: Passes the global context instead of |this| in JS. |this| in JS (args.Holder() in C++ code) is not a reliable object. User script can pass any object as |this|. So we shouldn't use it as creation context when calling Blink APIs to create a new DOM wrapper. We should instead use the current context where the user script is running as creation context. BUG=497507 Committed: https://crrev.com/42bd05a2bf4260f500687a2457d01e298033f2bb Cr-Commit-Position: refs/heads/master@{#334366}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -43 lines) Patch
M chrome/renderer/extensions/file_manager_private_custom_bindings.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/media_galleries_custom_bindings.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/renderer/extensions/media_galleries_custom_bindings.cc View 2 chunks +11 lines, -12 lines 0 comments Download
M chrome/renderer/extensions/page_capture_custom_bindings.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/renderer/extensions/sync_file_system_custom_bindings.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/app_runtime_custom_bindings.h View 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/renderer/app_runtime_custom_bindings.cc View 3 chunks +16 lines, -13 lines 0 comments Download
M extensions/renderer/blob_native_handler.h View 1 chunk +3 lines, -0 lines 0 comments Download
M extensions/renderer/blob_native_handler.cc View 3 chunks +17 lines, -12 lines 0 comments Download
M extensions/renderer/file_system_natives.cc View 3 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Yuki
kalman, could you review this CL as an owner of chrome/renderer/extensions/ and extensions/ ?
4 years, 5 months ago (2015-06-12 07:30:36 UTC) #2
haraken
non-owner LGTM
4 years, 5 months ago (2015-06-12 07:34:25 UTC) #3
not at google - send to devlin
lgtm
4 years, 5 months ago (2015-06-12 16:01:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1174343003/1
4 years, 5 months ago (2015-06-15 06:06:11 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2015-06-15 08:17:19 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2015-06-15 08:18:37 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/42bd05a2bf4260f500687a2457d01e298033f2bb
Cr-Commit-Position: refs/heads/master@{#334366}

Powered by Google App Engine
This is Rietveld 408576698