Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Side by Side Diff: chrome/renderer/extensions/media_galleries_custom_bindings.cc

Issue 1174343003: blink:bindings: Passes the global context instead of |this| in JS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/renderer/extensions/media_galleries_custom_bindings.h" 5 #include "chrome/renderer/extensions/media_galleries_custom_bindings.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "extensions/renderer/script_context.h" 9 #include "extensions/renderer/script_context.h"
10 #include "storage/common/fileapi/file_system_util.h" 10 #include "storage/common/fileapi/file_system_util.h"
11 #include "third_party/WebKit/public/web/WebDOMFileSystem.h" 11 #include "third_party/WebKit/public/web/WebDOMFileSystem.h"
12 #include "third_party/WebKit/public/web/WebDocument.h" 12 #include "third_party/WebKit/public/web/WebDocument.h"
13 #include "third_party/WebKit/public/web/WebLocalFrame.h" 13 #include "third_party/WebKit/public/web/WebLocalFrame.h"
14 #include "v8/include/v8.h" 14 #include "v8/include/v8.h"
15 15
16 namespace extensions { 16 namespace extensions {
17 17
18 namespace { 18 MediaGalleriesCustomBindings::MediaGalleriesCustomBindings(
19 ScriptContext* context)
20 : ObjectBackedNativeHandler(context) {
21 RouteFunction(
22 "GetMediaFileSystemObject",
23 base::Bind(&MediaGalleriesCustomBindings::GetMediaFileSystemObject,
24 base::Unretained(this)));
25 }
19 26
20 // FileSystemObject GetMediaFileSystem(string file_system_url): construct 27 // FileSystemObject GetMediaFileSystem(string file_system_url): construct
21 // a file system object from a file system url. 28 // a file system object from a file system url.
22 void GetMediaFileSystemObject(const v8::FunctionCallbackInfo<v8::Value>& args) { 29 void MediaGalleriesCustomBindings::GetMediaFileSystemObject(
30 const v8::FunctionCallbackInfo<v8::Value>& args) {
23 CHECK_EQ(1, args.Length()); 31 CHECK_EQ(1, args.Length());
24 CHECK(args[0]->IsString()); 32 CHECK(args[0]->IsString());
25 33
26 std::string fs_mount(*v8::String::Utf8Value(args[0])); 34 std::string fs_mount(*v8::String::Utf8Value(args[0]));
27 CHECK(!fs_mount.empty()); 35 CHECK(!fs_mount.empty());
28 36
29 blink::WebLocalFrame* webframe = 37 blink::WebLocalFrame* webframe =
30 blink::WebLocalFrame::frameForCurrentContext(); 38 blink::WebLocalFrame::frameForCurrentContext();
31 const GURL origin = GURL(webframe->document().securityOrigin().toString()); 39 const GURL origin = GURL(webframe->document().securityOrigin().toString());
32 std::string fs_name = 40 std::string fs_name =
33 storage::GetFileSystemName(origin, storage::kFileSystemTypeExternal); 41 storage::GetFileSystemName(origin, storage::kFileSystemTypeExternal);
34 fs_name.append("_"); 42 fs_name.append("_");
35 fs_name.append(fs_mount); 43 fs_name.append(fs_mount);
36 const GURL root_url( 44 const GURL root_url(
37 storage::GetExternalFileSystemRootURIString(origin, fs_mount)); 45 storage::GetExternalFileSystemRootURIString(origin, fs_mount));
38 args.GetReturnValue().Set( 46 args.GetReturnValue().Set(
39 blink::WebDOMFileSystem::create(webframe, 47 blink::WebDOMFileSystem::create(webframe,
40 blink::WebFileSystemTypeExternal, 48 blink::WebFileSystemTypeExternal,
41 blink::WebString::fromUTF8(fs_name), 49 blink::WebString::fromUTF8(fs_name),
42 root_url) 50 root_url)
43 .toV8Value(args.Holder(), args.GetIsolate())); 51 .toV8Value(context()->v8_context()->Global(), args.GetIsolate()));
44 }
45
46 } // namespace
47
48 MediaGalleriesCustomBindings::MediaGalleriesCustomBindings(
49 ScriptContext* context)
50 : ObjectBackedNativeHandler(context) {
51 RouteFunction("GetMediaFileSystemObject",
52 base::Bind(&GetMediaFileSystemObject));
53 } 52 }
54 53
55 } // namespace extensions 54 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698