chrome/renderer/extensions/file_manager_private_custom_bindings.cc - Issue 1174343003: blink:bindings: Passes the global context instead of |this| in JS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/extensions/file_manager_private_custom_bindings.cc

Issue 1174343003: blink:bindings: Passes the global context instead of |this| in JS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/renderer/extensions/file_manager_private_custom_bindings.cc

diff --git a/chrome/renderer/extensions/file_manager_private_custom_bindings.cc b/chrome/renderer/extensions/file_manager_private_custom_bindings.cc

index 2737e78f1fb0417b0f2601532c4f9aa3aa2495f8..0c50160e08532f15ad569425d48d6fc9afd9d3da 100644

--- a/chrome/renderer/extensions/file_manager_private_custom_bindings.cc

+++ b/chrome/renderer/extensions/file_manager_private_custom_bindings.cc

@@ -40,7 +40,7 @@ void FileManagerPrivateCustomBindings::GetFileSystem(

blink::WebFileSystemTypeExternal,

blink::WebString::fromUTF8(name),

GURL(root_url))

- .toV8Value(args.Holder(), args.GetIsolate()));

+ .toV8Value(context()->v8_context()->Global(), args.GetIsolate()));

}

} // namespace extensions

« no previous file with comments | « no previous file | chrome/renderer/extensions/media_galleries_custom_bindings.h » ('j') | no next file with comments »