extensions/renderer/app_runtime_custom_bindings.h - Issue 1174343003: blink:bindings: Passes the global context instead of |this| in JS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/app_runtime_custom_bindings.h

Issue 1174343003: blink:bindings: Passes the global context instead of |this| in JS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/extensions/sync_file_system_custom_bindings.cc ('k') | extensions/renderer/app_runtime_custom_bindings.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/renderer/app_runtime_custom_bindings.h

diff --git a/extensions/renderer/app_runtime_custom_bindings.h b/extensions/renderer/app_runtime_custom_bindings.h

index f4ff9068bd2458d6a762650145685371341c1e51..e0aba8a354a12882a2ff4da56a8e2c74edbfa0ec 100644

--- a/extensions/renderer/app_runtime_custom_bindings.h

+++ b/extensions/renderer/app_runtime_custom_bindings.h

@@ -15,6 +15,8 @@ class AppRuntimeCustomBindings : public ObjectBackedNativeHandler {

explicit AppRuntimeCustomBindings(ScriptContext* context);

private:

+ void CreateBlob(const v8::FunctionCallbackInfo<v8::Value>& args);

DISALLOW_COPY_AND_ASSIGN(AppRuntimeCustomBindings);

};