chrome/renderer/extensions/page_capture_custom_bindings.cc - Issue 1174343003: blink:bindings: Passes the global context instead of |this| in JS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/extensions/page_capture_custom_bindings.cc

Issue 1174343003: blink:bindings: Passes the global context instead of |this| in JS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/extensions/media_galleries_custom_bindings.cc ('k') | chrome/renderer/extensions/sync_file_system_custom_bindings.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/extensions/page_capture_custom_bindings.cc

diff --git a/chrome/renderer/extensions/page_capture_custom_bindings.cc b/chrome/renderer/extensions/page_capture_custom_bindings.cc

index d3086e94e54562892ff05c4ad84d83a623f0e210..bcc2e4981ebb6f1e96297b89e5f8697fb097a0f5 100644

--- a/chrome/renderer/extensions/page_capture_custom_bindings.cc

+++ b/chrome/renderer/extensions/page_capture_custom_bindings.cc

@@ -32,7 +32,8 @@ void PageCaptureCustomBindings::CreateBlob(

blink::WebString path(base::UTF8ToUTF16(*v8::String::Utf8Value(args[0])));

blink::WebBlob blob =

blink::WebBlob::createFromFile(path, args[1]->Int32Value());

- args.GetReturnValue().Set(blob.toV8Value(args.Holder(), args.GetIsolate()));

+ args.GetReturnValue().Set(

+ blob.toV8Value(context()->v8_context()->Global(), args.GetIsolate()));

}

void PageCaptureCustomBindings::SendResponseAck(