Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Unified Diff: chrome/renderer/extensions/page_capture_custom_bindings.cc

Issue 1174343003: blink:bindings: Passes the global context instead of |this| in JS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/page_capture_custom_bindings.cc
diff --git a/chrome/renderer/extensions/page_capture_custom_bindings.cc b/chrome/renderer/extensions/page_capture_custom_bindings.cc
index d3086e94e54562892ff05c4ad84d83a623f0e210..bcc2e4981ebb6f1e96297b89e5f8697fb097a0f5 100644
--- a/chrome/renderer/extensions/page_capture_custom_bindings.cc
+++ b/chrome/renderer/extensions/page_capture_custom_bindings.cc
@@ -32,7 +32,8 @@ void PageCaptureCustomBindings::CreateBlob(
blink::WebString path(base::UTF8ToUTF16(*v8::String::Utf8Value(args[0])));
blink::WebBlob blob =
blink::WebBlob::createFromFile(path, args[1]->Int32Value());
- args.GetReturnValue().Set(blob.toV8Value(args.Holder(), args.GetIsolate()));
+ args.GetReturnValue().Set(
+ blob.toV8Value(context()->v8_context()->Global(), args.GetIsolate()));
}
void PageCaptureCustomBindings::SendResponseAck(

Powered by Google App Engine
This is Rietveld 408576698