Fix the API for ServiceFactoryBinder to be type safe.

Fix the API for ServiceFactoryBinder to be type safe.

R=ppi@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/24ffae5460e05c3bc3f01c426d337d69e2003ec6

[ppi, 2015-06-05 09:39:43]

https://codereview.chromium.org/1169543002/diff/1/mojo/public/java/applicatio...
File
mojo/public/java/application/src/org/chromium/mojo/application/ApplicationConnection.java
(right):

https://codereview.chromium.org/1169543002/diff/1/mojo/public/java/applicatio...
mojo/public/java/application/src/org/chromium/mojo/application/ApplicationConnection.java:99:
.bind(InterfaceRequest.asInterfaceRequestUnsafe(pipe));
nit: wdyt about moving ".bind(" to the line above?

https://codereview.chromium.org/1169543002/diff/1/mojo/public/java/applicatio...
File
mojo/public/java/application/src/org/chromium/mojo/application/ServiceFactoryBinder.java
(right):

https://codereview.chromium.org/1169543002/diff/1/mojo/public/java/applicatio...
mojo/public/java/application/src/org/chromium/mojo/application/ServiceFactoryBinder.java:18:
* Bind an instance of the interface to the given request.
Does it *create* the instance that it binds? If so, can we say "Creates and
binds an instance of the service to the given request."?

https://codereview.chromium.org/1169543002/diff/1/mojo/public/java/applicatio...
mojo/public/java/application/src/org/chromium/mojo/application/ServiceFactoryBinder.java:25:
* Returns the mame of the service interface being implemented.
s/mame/name/

https://codereview.chromium.org/1169543002/diff/1/mojo/public/java/bindings/s...
File mojo/public/java/bindings/src/org/chromium/mojo/bindings/Interface.java
(right):

https://codereview.chromium.org/1169543002/diff/1/mojo/public/java/bindings/s...
mojo/public/java/bindings/src/org/chromium/mojo/bindings/Interface.java:45: *
Unbind the proxy and pass the handle. Can return null if the proxy is not bound
or if
s/Unbind/Unbinds/, s/pass/passes/

https://codereview.chromium.org/1169543002/diff/1/mojo/public/java/bindings/s...
mojo/public/java/bindings/src/org/chromium/mojo/bindings/Interface.java:168:
public MessagePipeHandle passHandle() {
If the part about addings passHandle to proxies is independent from the
ServiceFactoryBinder change, I'd suggest to split it out into a separate CL - so
that anyone interested in looking at one of these two changes but not at the
other will have a clearer picture. Wdyt?

https://codereview.chromium.org/1169543002/diff/1/mojo/public/java/bindings/s...
File
mojo/public/java/bindings/src/org/chromium/mojo/bindings/InterfaceRequest.java
(right):

https://codereview.chromium.org/1169543002/diff/1/mojo/public/java/bindings/s...
mojo/public/java/bindings/src/org/chromium/mojo/bindings/InterfaceRequest.java:51:
* Returns an {@link InterfaceRequest} that wraps the given handle. This method
is not type sage
s/sage/safe/

[qsr, 2015-06-05 11:19:53]

https://codereview.chromium.org/1169543002/diff/1/mojo/public/java/applicatio...
File
mojo/public/java/application/src/org/chromium/mojo/application/ApplicationConnection.java
(right):

https://codereview.chromium.org/1169543002/diff/1/mojo/public/java/applicatio...
mojo/public/java/application/src/org/chromium/mojo/application/ApplicationConnection.java:99:
.bind(InterfaceRequest.asInterfaceRequestUnsafe(pipe));
On 2015/06/05 09:39:42, ppi wrote:
> nit: wdyt about moving ".bind(" to the line above?

 git cl format did this. I do not want to fight against it :)

https://codereview.chromium.org/1169543002/diff/1/mojo/public/java/applicatio...
File
mojo/public/java/application/src/org/chromium/mojo/application/ServiceFactoryBinder.java
(right):

https://codereview.chromium.org/1169543002/diff/1/mojo/public/java/applicatio...
mojo/public/java/application/src/org/chromium/mojo/application/ServiceFactoryBinder.java:18:
* Bind an instance of the interface to the given request.
On 2015/06/05 09:39:43, ppi wrote:
> Does it *create* the instance that it binds? If so, can we say "Creates and
> binds an instance of the service to the given request."?

 It does whatever it wants. It might create an instance, or bind multiple pipe
to the same instance, or close the pipe, or whatever seems fine to it.

https://codereview.chromium.org/1169543002/diff/1/mojo/public/java/applicatio...
mojo/public/java/application/src/org/chromium/mojo/application/ServiceFactoryBinder.java:25:
* Returns the mame of the service interface being implemented.
On 2015/06/05 09:39:43, ppi wrote:
> s/mame/name/

Done.

https://codereview.chromium.org/1169543002/diff/1/mojo/public/java/bindings/s...
File mojo/public/java/bindings/src/org/chromium/mojo/bindings/Interface.java
(right):

https://codereview.chromium.org/1169543002/diff/1/mojo/public/java/bindings/s...
mojo/public/java/bindings/src/org/chromium/mojo/bindings/Interface.java:45: *
Unbind the proxy and pass the handle. Can return null if the proxy is not bound
or if
On 2015/06/05 09:39:43, ppi wrote:
> s/Unbind/Unbinds/, s/pass/passes/

Done.

https://codereview.chromium.org/1169543002/diff/1/mojo/public/java/bindings/s...
mojo/public/java/bindings/src/org/chromium/mojo/bindings/Interface.java:168:
public MessagePipeHandle passHandle() {
On 2015/06/05 09:39:43, ppi wrote:
> If the part about addings passHandle to proxies is independent from the
> ServiceFactoryBinder change, I'd suggest to split it out into a separate CL -
so
> that anyone interested in looking at one of these two changes but not at the
> other will have a clearer picture. Wdyt?

Done.

https://codereview.chromium.org/1169543002/diff/1/mojo/public/java/bindings/s...
File
mojo/public/java/bindings/src/org/chromium/mojo/bindings/InterfaceRequest.java
(right):

https://codereview.chromium.org/1169543002/diff/1/mojo/public/java/bindings/s...
mojo/public/java/bindings/src/org/chromium/mojo/bindings/InterfaceRequest.java:51:
* Returns an {@link InterfaceRequest} that wraps the given handle. This method
is not type sage
On 2015/06/05 09:39:43, ppi wrote:
> s/sage/safe/

Done.

[ppi, 2015-06-05 11:25:09]

lgtm % updating the commit name. Should this now say "Fix the API for
ServiceFactoryBinder to be type safe." ?

https://codereview.chromium.org/1169543002/diff/20001/mojo/public/java/applic...
File
mojo/public/java/application/src/org/chromium/mojo/application/ServiceFactoryBinder.java
(right):

https://codereview.chromium.org/1169543002/diff/20001/mojo/public/java/applic...
mojo/public/java/application/src/org/chromium/mojo/application/ServiceFactoryBinder.java:18:
* Bind an instance of the interface to the given request.
s/Bind/Binds/

[qsr, 2015-06-05 11:30:29]

https://codereview.chromium.org/1169543002/diff/20001/mojo/public/java/applic...
File
mojo/public/java/application/src/org/chromium/mojo/application/ServiceFactoryBinder.java
(right):

https://codereview.chromium.org/1169543002/diff/20001/mojo/public/java/applic...
mojo/public/java/application/src/org/chromium/mojo/application/ServiceFactoryBinder.java:18:
* Bind an instance of the interface to the given request.
On 2015/06/05 11:25:09, ppi wrote:
> s/Bind/Binds/

Done.

[qsr, 2015-06-05 11:31:05]

Committed patchset #4 (id:60001) manually as
24ffae5460e05c3bc3f01c426d337d69e2003ec6 (presubmit successful).