services/location/src/org/chromium/services/location/LocationServiceApp.java - Issue 1169543002: Fix the API for ServiceFactoryBinder to be type safe.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/location/src/org/chromium/services/location/LocationServiceApp.java

Issue 1169543002: Fix the API for ServiceFactoryBinder to be type safe. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « services/device_info/src/org/chromium/services/device_info/DeviceInfoService.java ('k') | services/sensors/src/org/chromium/mojo/sensors/Sensors.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: services/location/src/org/chromium/services/location/LocationServiceApp.java

diff --git a/services/location/src/org/chromium/services/location/LocationServiceApp.java b/services/location/src/org/chromium/services/location/LocationServiceApp.java

index 685b8fac84a93fe2a22ee9a07e7f8447366ee454..f82608f664364737537efd02ba1066ac2577dda0 100644

--- a/services/location/src/org/chromium/services/location/LocationServiceApp.java

+++ b/services/location/src/org/chromium/services/location/LocationServiceApp.java

@@ -16,6 +16,7 @@ import org.chromium.mojo.application.ApplicationConnection;

import org.chromium.mojo.application.ApplicationDelegate;

import org.chromium.mojo.application.ApplicationRunner;

import org.chromium.mojo.application.ServiceFactoryBinder;

+import org.chromium.mojo.bindings.InterfaceRequest;

import org.chromium.mojo.system.Core;

import org.chromium.mojo.system.MessagePipeHandle;

import org.chromium.mojom.mojo.LocationService;

@@ -104,11 +105,11 @@ class LocationServiceApp implements ApplicationDelegate {

public boolean configureIncomingConnection(ApplicationConnection connection) {

connection.addService(new ServiceFactoryBinder<LocationService>() {

@Override

- public void bindNewInstanceToMessagePipe(MessagePipeHandle pipe) {

+ public void bind(InterfaceRequest<LocationService> request) {

LocationService.MANAGER.bind(

new LocationServiceImpl(mGoogleApiClient, mLooperThread.getLooper(),

mCore.getCurrentRunLoop()),

- pipe);

+ request);

}

@Override